about summary refs log tree commit diff
path: root/ui-refs.c (follow)
Commit message (Expand)AuthorAge
* ui-refs: use shared function to print tag downloadsJohn Keeping2018-06-27
* ui-refs: remove unnecessary sanity checkJohn Keeping2018-06-27
* Add "snapshot-prefix" repo configurationJohn Keeping2018-06-27
* Avoid ambiguities when prettifying snapshot namesLukas Fleischer2016-07-05
* ui: show ages in the originator's timezoneJohn Keeping2016-02-08
* ui-shared: remove "format" from cgit_print_age()John Keeping2016-02-08
* ui-refs: remove useless null checkJohn Keeping2015-10-09
* refs: move layout to page functionJohn Keeping2015-08-14
* log: allow users to follow a fileJohn Keeping2015-08-12
* Avoid non-ANSI function declarationsJohn Keeping2015-03-09
* tag: reference with "h" instead of "id"John Keeping2015-01-19
* ui-shared: remove toggle_ssdiff arg to cgit_commit_link()John Keeping2014-12-13
* git: update for git 2.0Christian Hesse2014-06-28
* ui-refs: simplify cmp_age logicJason A. Donenfeld2014-02-26
* print download link for reference string length == 1Christian Hesse2014-02-21
* filter: add page source to email filterJason A. Donenfeld2014-01-14
* filter: add support for email filterJason A. Donenfeld2014-01-14
* ui-refs: escape HTML chars in author and tagger namesJohn Keeping2014-01-12
* Replace most uses of strncmp() with prefixcmp()Lukas Fleischer2014-01-10
* Update copyright informationLukas Fleischer2014-01-08
* Add branch-sort and repo.branch-sort options.Jason A. Donenfeld2013-04-10
* use struct strbuf instead of static buffersJohn Keeping2013-04-08
* ui-refs.c: Refactor print_tag()Lukas Fleischer2013-04-08
* ui-refs.c: Remove global header variableLukas Fleischer2013-04-08
* Always #include corresponding .h in .c filesJohn Keeping2013-04-08
* Fix colspan valuesLukas Fleischer2013-03-20
* print_tag_downloads(): Free ref variableLukas Fleischer2013-03-04
* Free reflists after usageLukas Fleischer2013-03-04
* White space around control verbs.Jason A. Donenfeld2013-03-04
* Fix several whitespace errorsLukas Fleischer2013-03-04
* Merge branch 'stable'Lars Hjemli2010-08-03
|\
| * ui-refs.c: avoid segfault on unparsed ref objectsLars Hjemli2010-08-03
* | ui-commit: Preserve path limit in links to commit pageJohan Herland2010-06-19
* | Merge branch 'lh/remote-branches'Lars Hjemli2009-12-08
|\ \
| * | Add support for remote branchesLars Hjemli2009-11-07
| |/
* / Add possibility to switch between unidiff and side-by-side-diff.Ragnar Ouchterlony2009-09-16
|/
* ui-refs.c: improve handling of lightweight tagsStefan Bühler2009-08-16
* Make all tags viewableRobin Redeker2009-01-11
* ui-refs: avoid SEGFAULT on lightweight tagsRobin Redeker2009-01-10
* Merge branch 'full-log'Lars Hjemli2008-12-06
|\
| * ui-log: add support for showing the full commit messageLars Hjemli2008-11-29
* | ui-refs.c: show download links for all tags referring to commit objectsLars Hjemli2008-12-01
|/
* ui-refs: use cgit_tag_link()Lars Hjemli2008-10-05
* Make branches, tags and log play better together in the summary viewLars Hjemli2008-04-14
* Add ui-shared.hLars Hjemli2008-03-24
* Add separate header-files for each page/viewLars Hjemli2008-03-24
* Introduce html.hLars Hjemli2008-03-18
* Introduce struct cgit_contextLars Hjemli2008-02-16
* Add support for refs viewLars Hjemli2007-10-27
generated by cgit-pink 1.4.1 (git 2.36.1) at 2025-02-17 10:46:01 +0000
correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu