about summary refs log tree commit diff
path: root/ui-tag.c (unfollow)
Commit message (Expand)Author
2012-01-03Fix diff mode switching when side-by-side-diffs=1Tim Chen
2012-01-03ui-log.c: do not show remote heads if enable-remote-branches=0Georg Müller
2012-01-03Add sort parameter to pager of repo listTobias Grimm
2012-01-03ui-ssdiff: move LCS table away from the stackJamie Couture
2012-01-03shared.c: Only setenv() if value is non-nullLukas Fleischer
2012-01-03shared.c: Remove unused "linux/limits.h" includeLukas Fleischer
2011-07-22Fix potential XSS vulnerability in rename hintLukas Fleischer
2011-07-22Remove dead initialization in cgit_parse_commit()Lukas Fleischer
2011-07-21CGIT 0.9.0.2Lars Hjemli
2011-07-21html.c: avoid out-of-bounds access for url_escape_tableEric Wong
2011-07-21tests: fix failures when CDPATH is setFerry Huberts
2011-07-19Makefile: fix oversight of not using $(DESTDIR) in uninstallFerry Huberts
2011-07-19commit-links.sh: improve regular expressionsFerry Huberts
2011-06-18cgit.c: improve error message when git repo cannot be accessedLars Hjemli
2011-06-15cgitrc.5.txt: document repo.module-linkLars Hjemli
2011-06-13cgit.c: add 'clone-url' setting with support for macro expansionLars Hjemli
2011-06-13cgit.c: always setup cgit repo environment variablesLars Hjemli
2011-06-13cgitrc.5.txt: reformat the "FILTER API" sectionLars Hjemli
2011-06-13cgitrc.5.txt: describe macro expansion of cgitrc optionsLars Hjemli
2011-06-13README: update some stale information/add some newLars Hjemli
2011-06-13CGIT 0.9.0.1Lars Hjemli
2011-06-12ui-plain.c: fix html and links generated by print_dir() and print_dir_entry()Lars Hjemli
2011-06-06scan-tree.c: avoid memory leakJamie Couture
2011-06-02ui-log.c: do not link from age columnLars Hjemli
2011-06-02ui-snapshot.c: remove debug cruftLars Hjemli
2011-05-30ui-stats.c: fix invalid htmlLars Hjemli
2011-05-30Properly escape ampersands inside HTML attributesLukas Fleischer
2011-05-30ui_repolist: get modtime from packed-refs as fallbackFerry Huberts
2011-05-23fix virtual-root if script-name is ""Mark Lodato
2011-05-23ui-repolist.c: do not return random/stale data from read_agefileLars Hjemli
2011-05-23Avoid null pointer dereference in cgit_print_diff().Lukas Fleischer
2011-05-23Avoid null pointer dereference in reencode().Lukas Fleischer
2011-05-23Fix memory leak in http_parse_querystring().Lukas Fleischer
2011-05-23Remove unused variable from cgit_diff_tree().Lukas Fleischer
2011-05-23shared.c: do not modify const memoryLars Hjemli
2011-05-23tests: add tests for links with space in path and/or argsLars Hjemli
2011-05-23tests/setup.sh: add support for known bugsLars Hjemli
2011-05-23Fix escaping of paths with spacesJonathon Mah
2011-03-26Add advice about scan-path in cgitrc.5.txtJulius Plenz
2011-03-26fix two encoding bugsJulius Plenz
2011-03-26make enable-log-linecount independent of -filecountJulius Plenz
2011-03-26new_filter: correctly initialise all arguments for a new filterFerry Huberts
2011-03-26source_filter: fix a memory leakFerry Huberts
2011-03-26cgitrc.5: tar.xz is a supported snapshot formatLars Hjemli
2011-03-26Fix crash when projectsfile cannot be openedStefan Gehn
2011-03-26shared.c: use execvp() to execute filter commandsLars Hjemli
2011-03-26filters: document environment variables in filter scriptsFerry Huberts
2011-03-26cgit_open_filter: hand down repo configuration to scriptFerry Huberts
2011-03-26cgit_open_filter: also take the repo as a parameterFerry Huberts
2011-03-26new_filter: determine extra_args from filter typeFerry Huberts
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-10-04 01:26:16 +0000
f978edd2a40c2721e1efdc1eee2343&follow=1'>ui-summary: add "rel='vcs-git'" to clone URL linksJohn Keeping This is described in the rel-vcs microformat[1]. [1] https://joeyh.name/rfc/rel-vcs/ Signed-off-by: John Keeping <john@keeping.me.uk> 2014-12-23Extract clone URL printing to ui-shared.cJohn Keeping This will allow us to reuse the same logic to add clone URL <link/> elements to the header of all repo-specific pages in order to support the rel-vcs microformat. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-12-23Remove trailing slash after remove-suffixLukas Fleischer When removing the ".git" suffix of a non-bare repository, also remove the trailing slash for compatibility with cgit_repobasename(). Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de> 2014-12-23git: update to v2.2.1Christian Hesse Update to git version v2.2.1, including API changes. Signed-off-by: Christian Hesse <mail@eworm.de> 2014-12-13filter: fix libravatar email-filter https issueChristian Hesse Serving cgit via https and getting avatar via http gives error messages about untrusted content. This decides whether or not to use https link by looking at the environment variable HTTPS, which is set in CGI. 2014-12-13ui-diff: add "stat only" diff typeJohn Keeping This prints the diffstat but stops before printing (or generating) any of the body of the diff. No cgitrc option is added here so that we can wait to see how useful this is before letting people set it as the default. Suggested-by: Konstantin Ryabitsev <mricon@kernel.org> Signed-off-by: John Keeping <john@keeping.me.uk> 2014-12-13Change "ss" diff flag to an enumJohn Keeping This will allow us to introduce a new "stat only" diff mode without needing an explosion of mutually incompatible flags. The old "ss" query parameter is still accepted in order to avoid breaking saved links, but we no longer generate any URIs using it; instead the new "dt" (diff type) parameter is used. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-12-13ui-shared: remove toggle_ssdiff arg to cgit_diff_link()John Keeping This argument is never used with a value other than zero, so remove it and simplify the code. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-12-13ui-shared: remove toggle_ssdiff arg to cgit_commit_link()John Keeping This argument is never used with a value other than zero, so remove it and simplify the code. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-08-07git: update to v2.0.4John Keeping No CGit changes required. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-08-07Always check if README exists in choose_readme()Lukas Fleischer Specifying a nonexistent README file via the readme option is sometimes useful, e.g. when using scan-path and setting a global default. Currently, we check whether there is only one option in the readme option and, if so, we choose that file without checking whether it exists. As a consequence, all repositories are equipped with an about link in the aforementioned scenario, even if there is no about file. Remove the early check for the number of keys and always check whether the file exists instead. Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de> 2014-08-01cgitrc.5: we mean a cgi response, not requestJason A. Donenfeld 2014-07-28ui-stats.c: set parent pointer to NULL after freeing itJohn Keeping We do this everywhere else, so we should be doing it here as well. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-07-28git: update to v2.0.3John Keeping This is slightly more involved than just bumping the version number because it pulls in a change to convert the commit buffer to a slab, removing the "buffer" field from "struct commit". All sites that access "commit->buffer" have been changed to use the new functions provided for this purpose. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-07-28parsing.c: make commit buffer constJohn Keeping This will be required in order to incorporate the changes to commit buffer handling in Git 2.0.2. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-06-30Bump version.Jason A. Donenfeld 2014-06-29remove debug fprinf() calls that sneaked in with commit 79c985Christian Hesse 2014-06-28git: update to 2.0.1Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-06-28ui-patch: Flush stdout after outputting dataJohn Keeping It looks like cached patches are truncated to the nearest 1024-byte boundary in the patch body. E.g.: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:34:51 (80.4 MB/s) - ‘no-cache’ saved [4767] Patch is complete, without truncation. Next hit, with cache in place: > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4 > fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:35:01 (17.0 MB/s) - ‘yes-cache’ saved [4096/4096] Length truncated to 4096. The cache on disk looks truncated as well, so the bug must me during the process of saving cache. The same is true for larger patches: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:33 (1.07 MB/s) - ‘no-cache’ saved [979644] 979644 bytes with a cache-miss > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c > 566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:46 (1.05 MB/s) - ‘yes-cache’ saved [978944] 978944 (956KB exactly) with a cache-hit Since the "html" functions use raw write(2) to STDIO_FILENO, we don't notice problems with most pages, but raw patches write using printf(3). This is fine if we're outputting straight to stdout since the buffers are flushed on exit, but we close the cache output before this, so the cached output ends up being truncated. Make sure the buffers are flushed when we finish outputting a patch so that we avoid this. No other UIs use printf(3) so we do not need to worry about them. Actually, it's slightly more interesting than this... since we don't set GIT_FLUSH, Git decides whether or not it will flush stdout after writing each commit based on whether or not stdout points to a regular file (in maybe_flush_or_die()). Which means that when writing directly to the webserver, Git flushes stdout for us, but when we redirect stdout to the cache it points to a regular file so Git no longer flushes the output for us. The patch is still correct, but perhaps the full explanation is interesting! Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28ui-log: ignore unhandled argumentsJohn Keeping If you search for a bogus range string here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/ Using something like "range" and "qwerty123456", it returns an "Internal Server Error" and the following in the logs: > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] fatal: > ambiguous argument 'qwerty123456': unknown revision or path not in the > working tree., referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Use '--' to > separate paths from revisions, like this:, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] 'git <command> > [<revision>...] -- [<file>...]', referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Premature end > of script headers: cgit, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ The cache will kick in, so if you search for the same string again, it'll show an empty range, so you have to change the bogus strings each time. This is because we just pass the arguments straight to Git's revision parsing machinery which die()s if it cannot parse an argument, printing the above to stderr and exiting. The patch below makes it a bit friendlier by just ignoring unhandled arguments, but I can't see an easy way to report errors when we can't parse revision arguments without losing the flexibility of supporting all of the revision specifiers supported by Git. Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28git: update for git 2.0Christian Hesse prefixcmp() and suffixcmp() have been remove, functionality is now provided by starts_with() and ends_with(). Retrurn values have been changed, so instead of just renaming we have to fix logic. Everything else looks just fine. 2014-04-17remove trailing whitespaces from source filesChristian Hesse 2014-04-12git: update to 1.9.2Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-04-05Fix cgit_parse_url when a repo url is contained in another repo urlJulian Maurice For example, if I have two repos (remove-suffix is enabled): /foo /foo/bar http://cgit/foo/bar/ is interpreted as "repository 'foo', command 'bar'" instead of "repository 'foo/bar'" 2014-03-20Makefile: use more reliable git tarball mirrorJason A. Donenfeld 2014-03-20git: update to 1.9.1Christian Hesse