| Commit message (Expand) | Author |
| 2019-11-15 | Request NAMES on sync by default | June McEnroe |
| 2019-11-14 | Add concept of passive clients | June McEnroe |
| 2019-11-14 | Save and load full struct timeval | June McEnroe |
| 2019-11-14 | Use struct timeval for sub-second precision | June McEnroe |
| 2019-11-14 | Remove server-time filter TODO | June McEnroe |
| 2019-11-14 | Tweak filter regexes | June McEnroe |
| 2019-11-14 | Filter multi-prefix | June McEnroe |
| 2019-11-14 | Replace filters with regex replaces | June McEnroe |
| 2019-11-13 | Refactor filterUserhostInNames | June McEnroe |
| 2019-11-13 | Factor out wordcpy for filters | June McEnroe |
| 2019-11-11 | Revert "Test getopt_config" | June McEnroe |
| 2019-11-11 | Test getopt_config | June McEnroe |
| 2019-11-11 | Add userhost-in-names to manual | June McEnroe |
| 2019-11-11 | Skip initial NAMES parameters | June McEnroe |
| 2019-11-11 | Filter userhost-in-names | June McEnroe |
| 2019-11-10 | Compare words without copying in filters | June McEnroe |
| 2019-11-10 | Separate tags from all target | June McEnroe |
| 2019-11-10 | Filter invite-notify | June McEnroe |
| 2019-11-10 | Add capsicum note to README | June McEnroe |
| 2019-11-10 | Filter extended-join | June McEnroe |
| 2019-11-10 | Expand client configuration documentation and list capabilities | June McEnroe |
| 2019-11-10 | Request all supported caps from server | June McEnroe |
| 2019-11-10 | Filter ACCOUNT, AWAY, CHGHOST for incapable clients | June McEnroe |
| 2019-11-10 | Rename listen to local | June McEnroe |
| 2019-11-09 | Remove extended-join and invite-notify | June McEnroe |
| 2019-11-09 | Maintain stateCaps and offer them to clients | June McEnroe |
| 2019-11-09 | Parse capabilities | June McEnroe |
| 2019-11-09 | Avoid the reserved _A names with BIT macro | June McEnroe |
| 2019-11-09 | Define macro for bit flag enums | June McEnroe |
| 2019-11-08 | Check that password is hashed | June McEnroe |
| 2019-11-08 | Avoid calling getopt_long again after it returns -1 | June McEnroe |
| 2019-11-08 | Only change AWAY status for registered clients | June McEnroe |
| 2019-11-07 | Just write the example normally | June McEnroe |
| 2019-11-07 | Include path in readlinkat error | June McEnroe |
| 2019-11-07 | Call clientConsume before clientRecv | June McEnroe |
| 2019-11-06 | Use -l:filename in Linux.mk | June McEnroe |
| 2019-11-06 | Fix compat.h for #defined strlcpy | June McEnroe |
| 2019-11-06 | Allow unsetting LIBRESSL_PREFIX | June McEnroe |
| 2019-11-06 | Document calico service configuration | June McEnroe |
| 2019-11-06 | Document SASL EXTERNAL configuration in more detail | June McEnroe |
| 2019-11-06 | Document pounce service configuration | June McEnroe |
| 2019-11-06 | Mention Darwin and GNU/Linux in README | June McEnroe |
| 2019-11-06 | Assume LibreSSL from brew on Darwin | June McEnroe |
| 2019-11-06 | Remove -DNO_EXPLICIT_BZERO from Darwin.mk | June McEnroe |
| 2019-11-06 | Don't install rc scripts or dirs on Linux | June McEnroe0 | Bump version. | Jason A. Donenfeld |
|
|
|
|
|
Everything works just bumping the version in Makefile and commit hash in
submodule. No code changes required.
|
|
It looks like cached patches are truncated to the nearest 1024-byte
boundary in the patch body. E.g.:
> mricon@nikko:[/tmp]$ wget -O no-cache
> "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4fdad5157bb9e88777d525704aba24389bee"
...
> 2014-06-11 15:34:51 (80.4 MB/s) - ‘no-cache’ saved [4767]
Patch is complete, without truncation. Next hit, with cache in place:
> mricon@nikko:[/tmp]$ wget -O yes-cache
> "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4
> fdad5157bb9e88777d525704aba24389bee"
...
> 2014-06-11 15:35:01 (17.0 MB/s) - ‘yes-cache’ saved [4096/4096]
Length truncated to 4096. The cache on disk looks truncated as well, so
the bug must me during the process of saving cache. The same is true for
larger patches:
> mricon@nikko:[/tmp]$ wget -O no-cache
> "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c566e95599cd60c7143762ca8b49d9395050"
...
> 2014-06-11 15:41:33 (1.07 MB/s) - ‘no-cache’ saved [979644]
979644 bytes with a cache-miss
> mricon@nikko:[/tmp]$ wget -O yes-cache
> "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c
> 566e95599cd60c7143762ca8b49d9395050"
...
> 2014-06-11 15:41:46 (1.05 MB/s) - ‘yes-cache’ saved [978944]
978944 (956KB exactly) with a cache-hit
Since the "html" functions use raw write(2) to STDIO_FILENO, we don't
notice problems with most pages, but raw patches write using printf(3).
This is fine if we're outputting straight to stdout since the buffers
are flushed on exit, but we close the cache output before this, so the
cached output ends up being truncated.
Make sure the buffers are flushed when we finish outputting a patch so
that we avoid this.
No other UIs use printf(3) so we do not need to worry about them.
Actually, it's slightly more interesting than this... since we don't set
GIT_FLUSH, Git decides whether or not it will flush stdout after writing
each commit based on whether or not stdout points to a regular file (in
maybe_flush_or_die()).
Which means that when writing directly to the webserver, Git flushes
stdout for us, but when we redirect stdout to the cache it points to a
regular file so Git no longer flushes the output for us.
The patch is still correct, but perhaps the full explanation is
interesting!
Reported-by: Konstantin Ryabitsev <mricon@kernel.org>
|
|
If you search for a bogus range string here:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/
Using something like "range" and "qwerty123456", it returns an "Internal
Server Error" and the following in the logs:
> [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] fatal:
> ambiguous argument 'qwerty123456': unknown revision or path not in the
> working tree., referer:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/
> [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Use '--' to
> separate paths from revisions, like this:, referer:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/
> [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] 'git <command>
> [<revision>...] -- [<file>...]', referer:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/
> [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Premature end
> of script headers: cgit, referer:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/
The cache will kick in, so if you search for the same string again,
it'll show an empty range, so you have to change the bogus strings each
time.
This is because we just pass the arguments straight to Git's revision
parsing machinery which die()s if it cannot parse an argument, printing
the above to stderr and exiting.
The patch below makes it a bit friendlier by just ignoring unhandled
arguments, but I can't see an easy way to report errors when we can't
parse revision arguments without losing the flexibility of supporting
all of the revision specifiers supported by Git.
Reported-by: Konstantin Ryabitsev <mricon@kernel.org>
|
|
prefixcmp() and suffixcmp() have been remove, functionality is now
provided by starts_with() and ends_with(). Retrurn values have been
changed, so instead of just renaming we have to fix logic.
Everything else looks just fine.
|
|
|
|
Everything works just bumping the version in Makefile and commit hash in
submodule. No code changes required.
|
|
For example, if I have two repos (remove-suffix is enabled):
/foo
/foo/bar
http://cgit/foo/bar/ is interpreted as "repository 'foo', command 'bar'"
instead of "repository 'foo/bar'"
|
|
|