[BUILTIN] Fix NUL termination in readcmd - dash - patched shell with cmake build

summary refs log tree commit diff

path: root/src/funcs

diff options

author	Herbert Xu <herbert@gondor.apana.org.au>	2009-08-31 20:15:04 +1000
committer	Herbert Xu <herbert@gondor.apana.org.au>	2009-08-31 20:15:04 +1000
commit	cdb7c72699056856ac123d1ba4ab0e8595edbeb9 (patch)
tree	8c647123ecc64543556dd8c6cfd406ba9a535650 /src/funcs
parent	[EVAL] Revert SKIPEVAL into EXEXIT (diff)
download	dash-cdb7c72699056856ac123d1ba4ab0e8595edbeb9.tar.gz dash-cdb7c72699056856ac123d1ba4ab0e8595edbeb9.zip

[BUILTIN] Fix NUL termination in readcmd

Commit 55c46b7286f5d9f2d8291158203e2b61d2494420 ([BUILTIN] Honor
tab as IFS whitespace when splitting fields in readcmd) introduced
a bug where sometimes garbage would follow the last field preceding
the end-of-line.  This was caused by an off-by-one error in the
string length calculation.

This patch fixes the bug.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Diffstat (limited to '')

0 files changed, 0 insertions, 0 deletions

nroe 2021-02-01Remove use of "%n"June McEnroe https://cvsweb.openbsd.org/src/lib/libc/stdio/vfprintf.c?rev=1.79&content-type=text/x-cvsweb-markup I think this is silly, as I've said elsewhere, and it's a shame because that was clearly the best way to write this. Oh well. 2021-02-01Check signals first in the loopJune McEnroe Signals need to be checked first in the loop to catch any that were delivered between setting up the signals handlers and entering the loop, i.e. in the time it takes to initially start each of the services. 2020-12-15Log a message when stopping a service waiting to restart 1.1June McEnroe It's a little annoying to have to special-case this, but otherwise there is no confirmation in the log that the restart won't still happen. 2020-11-10Refactor unveil calls so errors can be reported properlyJune McEnroe 2020-10-27Do not increment signalsJune McEnroe No need to do a read and a write... and it's declared volatile so maybe that's even worse? I don't even know, but there's no point. 2020-10-23Only look up group if one is namedJune McEnroe 2020-10-23Remove default defines of RUNDIR, ETCDIRJune McEnroe 2020-10-23Set shell scripts executable in buildJune McEnroe 2020-10-20Humanize milliseconds if interval is less than 1sJune McEnroe The intervals are configurable in milliseconds so humanize should be able to display at that precision. 2020-10-20Humanize restart intervalJune McEnroe 2020-08-17Document default catsit.conf location on OpenBSD 1.0June McEnroe 2020-08-17Template catsit script with RUNDIRJune McEnroe 2020-08-17Clean up includesJune McEnroe 2020-08-17Log service uptime in statusJune McEnroe