summary refs log tree commit diff
path: root/src/error.h (unfollow)
Commit message (Expand)Author
2005-10-26[INPUT] Size optimisations in preadbuffer()Herbert Xu
2005-10-01[INPUT] Fix NUL skipping in preadbufferHerbert Xu
2005-09-26Added eflag fixes for trap and minusc.herbert
2005-09-26Removed unnecessary inclusion of eval.h from parser.c.herbert
2005-09-26Let evaltree handle traps from cmdloop.herbert
2005-09-26Handle SKIPEVAL in read_profile by exiting.herbert
2005-09-26Removed unnecessary inclusion of main.h from eval.c.herbert
2005-09-26Generalise setinputfile for use in read_profile/readcmdfile.herbert
2005-09-26Removed some unnecessary inclusions of input.h.herbert
2005-09-26Turn evalskip into a bit field.herbert
2005-09-26Eliminate first null termination in setvar.herbert
2005-09-26Add trailing equal sign in setvar for variables set to null.pape
2005-09-26Get rid of duplicate -g -O2 in CFLAGS.herbert
2005-09-26Cleaned up src/Makefile.am.herbert
2005-09-26Fixed support for cross-compilation.gilles.chanteperdrix
2005-09-26Do not clobber exit status in dotcmd.herbert
2005-09-26Removed redundant setstackmark from dotcmd.herbert
2005-09-26Removed qflag.herbert
2005-09-26Invert return value of test_eaccess and rename it to test_st_mode.herbert
2005-09-26Eliminate duplicate stat in test_eaccess.herbert
2005-09-26Optimised FILGZ test.herbert
2005-09-26Enclose abort insode ifdef DEBUG.herbert
2005-09-26Renamed error to sh_error.herbert
2005-09-26Normalise input in likely/unlikely macros.herbert
2005-09-26Removed expcmd built-in.herbert
2005-09-26Only set skipcount for break and continue.herbert
2005-09-26Update funcnest atomically.herbert
2005-09-26Replaced EXEVAL with SKIPEVAL.herbert
2005-09-26Corrected that/than typo in manual page.agcosta
2005-09-26Optimise away status and case statement in main().herbert
2005-09-26Eliminated global exerrno.herbert
2005-09-26Only reread exitstatus on EXEXIT in exitshell.herbert
2005-09-26Do not clobber exit status on EXEVAL.herbert
2005-09-26Size optimisations with state/s in main().herbert
2005-09-26Corrected grammar in manual page.agcosta
2005-09-26Catch set -e exits within built-in commands.herbert
2005-09-26Changed boolean rootshell into shlvl counter.herbert
2005-09-26Release 0.5.2.herbert
2005-09-26Corrected manual entry about ENV and non-interactive shells.pape
2005-09-26Removed debian files.herbert
2005-09-26Spell behaviour consistently in manual page.pape
2005-09-26Fixed spelling errors in manual page.agcosta
2005-09-26Fixed signed char promotion in src/expand.c.herbert
2005-09-26Size optimisations around varvalue() in src/expand.c.herbert
2005-09-26Fixed expansion when leading argument is null in src/expand.c.herbert
2005-09-26Allow negative pid argument to kill(1) in src/jobs.c.herbert
2005-09-26Fixed cd - when OLDPWD is unset.herbert
2005-09-26Include system.h.herbert
generated by cgit-pink 1.4.1 (git 2.36.1) at 2025-03-03 02:21:38 +0000
-pink/commit/git?id=390ffad022336b02dca6dec23504cefeb12adada&follow=1'>git: update to 2.0.1Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-06-28ui-patch: Flush stdout after outputting dataJohn Keeping It looks like cached patches are truncated to the nearest 1024-byte boundary in the patch body. E.g.: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:34:51 (80.4 MB/s) - ‘no-cache’ saved [4767] Patch is complete, without truncation. Next hit, with cache in place: > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4 > fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:35:01 (17.0 MB/s) - ‘yes-cache’ saved [4096/4096] Length truncated to 4096. The cache on disk looks truncated as well, so the bug must me during the process of saving cache. The same is true for larger patches: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:33 (1.07 MB/s) - ‘no-cache’ saved [979644] 979644 bytes with a cache-miss > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c > 566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:46 (1.05 MB/s) - ‘yes-cache’ saved [978944] 978944 (956KB exactly) with a cache-hit Since the "html" functions use raw write(2) to STDIO_FILENO, we don't notice problems with most pages, but raw patches write using printf(3). This is fine if we're outputting straight to stdout since the buffers are flushed on exit, but we close the cache output before this, so the cached output ends up being truncated. Make sure the buffers are flushed when we finish outputting a patch so that we avoid this. No other UIs use printf(3) so we do not need to worry about them. Actually, it's slightly more interesting than this... since we don't set GIT_FLUSH, Git decides whether or not it will flush stdout after writing each commit based on whether or not stdout points to a regular file (in maybe_flush_or_die()). Which means that when writing directly to the webserver, Git flushes stdout for us, but when we redirect stdout to the cache it points to a regular file so Git no longer flushes the output for us. The patch is still correct, but perhaps the full explanation is interesting! Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28ui-log: ignore unhandled argumentsJohn Keeping If you search for a bogus range string here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/ Using something like "range" and "qwerty123456", it returns an "Internal Server Error" and the following in the logs: > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] fatal: > ambiguous argument 'qwerty123456': unknown revision or path not in the > working tree., referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Use '--' to > separate paths from revisions, like this:, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] 'git <command> > [<revision>...] -- [<file>...]', referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Premature end > of script headers: cgit, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ The cache will kick in, so if you search for the same string again, it'll show an empty range, so you have to change the bogus strings each time. This is because we just pass the arguments straight to Git's revision parsing machinery which die()s if it cannot parse an argument, printing the above to stderr and exiting. The patch below makes it a bit friendlier by just ignoring unhandled arguments, but I can't see an easy way to report errors when we can't parse revision arguments without losing the flexibility of supporting all of the revision specifiers supported by Git. Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28git: update for git 2.0Christian Hesse prefixcmp() and suffixcmp() have been remove, functionality is now provided by starts_with() and ends_with(). Retrurn values have been changed, so instead of just renaming we have to fix logic. Everything else looks just fine. 2014-04-17remove trailing whitespaces from source filesChristian Hesse 2014-04-12git: update to 1.9.2Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-04-05Fix cgit_parse_url when a repo url is contained in another repo urlJulian Maurice For example, if I have two repos (remove-suffix is enabled): /foo /foo/bar http://cgit/foo/bar/ is interpreted as "repository 'foo', command 'bar'" instead of "repository 'foo/bar'" 2014-03-20Makefile: use more reliable git tarball mirrorJason A. Donenfeld 2014-03-20git: update to 1.9.1Christian Hesse