diff options
| author | June McEnroe <programble@gmail.com> | 2018-02-23 17:47:47 -0500 |
|---|---|---|
| committer | June McEnroe <programble@gmail.com> | 2018-02-23 17:47:47 -0500 |
| commit | 1d0db9488b958ef7d800b9ee9be176496be815d3 (patch) | |
| tree | 9999a9757980ba20c4981f36a6c03793277ca351 /bin | |
| parent | Clean up pbd (diff) | |
| download | src-1d0db9488b958ef7d800b9ee9be176496be815d3.tar.gz src-1d0db9488b958ef7d800b9ee9be176496be815d3.zip | |
Avoid unnecessary FDs in errors
Diffstat (limited to '')
| -rw-r--r-- | bin/dtch.c | 10 | ||||
| -rw-r--r-- | bin/hnel.c | 4 |
2 files changed, 7 insertions, 7 deletions
diff --git a/bin/dtch.c b/bin/dtch.c index 23407386..6fe85838 100644 --- a/bin/dtch.c +++ b/bin/dtch.c @@ -138,7 +138,7 @@ static int dtch(int argc, char *argv[]) { if (error) err(EX_IOERR, "%s", addr.sun_path); error = fcntl(server, F_SETFD, FD_CLOEXEC); - if (error) err(EX_IOERR, "fcntl(%d)", server); + if (error) err(EX_IOERR, "fcntl"); int pty; pid_t pid = forkpty(&pty, NULL, NULL, NULL); @@ -154,13 +154,13 @@ static int dtch(int argc, char *argv[]) { for (;;) { int client = accept(server, NULL, NULL); - if (client < 0) err(EX_IOERR, "accept(%d)", server); + if (client < 0) err(EX_IOERR, "accept"); ssize_t size = sendFd(client, pty); - if (size < 0) warn("sendmsg(%d)", client); + if (size < 0) warn("sendmsg"); size = recv(client, &z, sizeof(z), 0); - if (size < 0) warn("recv(%d)", client); + if (size < 0) warn("recv"); close(client); @@ -195,7 +195,7 @@ static int atch(int argc, char *argv[]) { if (error) err(EX_NOINPUT, "%s", addr.sun_path); int pty = recvFd(client); - if (pty < 0) err(EX_IOERR, "recvmsg(%d)", client); + if (pty < 0) err(EX_IOERR, "recvmsg"); struct winsize window; error = ioctl(STDERR_FILENO, TIOCGWINSZ, &window); diff --git a/bin/hnel.c b/bin/hnel.c index 81879429..0b365e51 100644 --- a/bin/hnel.c +++ b/bin/hnel.c @@ -60,7 +60,7 @@ int main(int argc, char *argv[]) { struct winsize window; error = ioctl(STDERR_FILENO, TIOCGWINSZ, &window); - if (error) err(EX_IOERR, "ioctl(%d, TIOCGWINSZ, ...)", STDERR_FILENO); + if (error) err(EX_IOERR, "TIOCGWINSZ"); int pty; pid_t pid = forkpty(&pty, NULL, NULL, &window); @@ -111,7 +111,7 @@ int main(int argc, char *argv[]) { int status; pid_t dead = waitpid(pid, &status, WNOHANG); - if (dead < 0) err(EX_OSERR, "waitpid(%d, ...)", pid); + if (dead < 0) err(EX_OSERR, "waitpid(%d)", pid); if (dead) return WIFEXITED(status) ? WEXITSTATUS(status) : EX_SOFTWARE; } err(EX_IOERR, "poll"); |