summary refs log tree commit diff
path: root/www/git.causal.agency/cgit/tests/valgrind
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2020-12-21 17:59:16 -0500
committerJune McEnroe <june@causal.agency>2020-12-21 17:59:16 -0500
commit6eabe3212a481dd8fc272fc68bc38c0c61949c63 (patch)
tree6b444f1c01cecdef9f70a685bbabb25c14d45d75 /www/git.causal.agency/cgit/tests/valgrind
parentMove rfc to doc/rfc (diff)
downloadsrc-6eabe3212a481dd8fc272fc68bc38c0c61949c63.tar.gz
src-6eabe3212a481dd8fc272fc68bc38c0c61949c63.zip
Move rfc.vim to doc/rfc
That default path is a bit wonky, but it prevents having to template
rfc.vim for basically no reason.
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions
/chat.c?h=twitch&id=b690bd0b83ffb6d29a1cd373635864bd1b086ac7&follow=1'>OpenBSD: Simplify promise creation after seprintf() introductionKlemens Nanni Just truncate the initial promises back to the final ones after pledging for the first time, saving code and memory. Assign `ptr' in all initial `seprintf()' calls for consistency while here. 2021-06-14OpenBSD: pledge final promises earlierKlemens Nanni No need to wait for so long. This also brings all the pledge code on one screen and helps show how ircConnect() is the only relevant part in between initial and final promises. 2021-06-14Treat `-T's optional argument as optionalKlemens Nanni `-T[format]' is not possible with getopt(3) but getopt_long(3) supports "T::" exactly for that, so make the command line option go in line with configuration files and documentation. While here, check `has_arg' explicitly as getopt_long(3) only documents mnemonic values not numerical ones. 2021-06-14Add \com text macroJune McEnroe 2021-06-13/exec without controlling terminalKlemens Nanni Otherwise "/exec sh </dev/tty" takes over and catgirl must effectively be killed to stop the madness; with this diff: catgirl input| /exec sh </dev/tty catgirl output| /bin/sh: cannot open /dev/tty: Device not configured catgirl output| Process exits with status 1 Do the same for `-C/Copy', `-N/notify' and `-O/open' alike. 2021-06-13Exit on data directory creation errorKlemens Nanni No point in creating (sub)directories when the given root failed already as is the case when e.g. XDG_DATA_HOME/catgirl/ itself is bogus (cleaned stderr intermangled with ncurses setup/catgirl output): $ env -i TERM=xterm XDG_DATA_HOME=/ ./catgirl -h irc.hackint.eu -n nobody -l catgirl: //catgirl/: Permission denied catgirl: //catgirl/log: No such file or directory catgirl: //catgirl/log/hackint: No such file or directory catgirl: //catgirl/log/hackint/NickServ: No such file or directory catgirl: //catgirl/: Permission denied catgirl: //catgirl/log/hackint/NickServ/2021-06-13.log: No such file or directory 2021-06-13OpenBSD: no need to read data files (logs)Klemens Nanni One of the last changes missed this, but it is a NOOP anyway since "rpath" is not pledged any longer. 2021-06-12Reset formatting after realname in setnameJune McEnroe Missed this one. 2021-06-11Fix unknown file signature errorJune McEnroe 2021-06-11Exclusively lock save fileJune McEnroe Prevents two instances of catgirl from using the same save file and clobbering each other's data. 2021-06-11Open save file with "a+"June McEnroe Avoids another small TOCTOU. Rewind before loading since "a+" sets the file position at the end. Remove unnecessary fseek after truncation, since "a+" always writes at the end of the file. 2021-06-11OpenBSD: Drop now unneeded file system access for save fileKlemens Nanni All opening happens before unveil/pledge and the file handle is kept open read/write so it can be used without any pledge. Simpler/less code and less chances to write other files (accidentially). 2021-06-11Open save file once in uiLoad() and keep it open until uiSave()Klemens Nanni Opening the same file *path* twice is a TOCTOU, although not a critical one: worst case we load from one file and save to another - the impact depends on how and when catgirl is started the next anyway. More importantly, keeping the file handle open at runtime allows us to drop all filesystem related promises for `-s/save' on OpenBSD. uiLoad() now opens "r+", meaning "Open for reading and writing." up front so uiSave() can write to it. In the case of a nonexistent save file, it now opens with "w" meaning "Open for writing. The file is created if it does not exist.", i.e. the same write/create semantics as "w" except uiLoad() no longer truncates. existing files. uiSave() now truncates the save file to avoid appending in general. 2021-06-11Rename file to saveFileKlemens Nanni Separate churn from actual change in upcoming diff, no functional change. 2021-06-11OpenBSD: Hoist loading save file to drop filesystem read-accessKlemens Nanni After TLS cert/key files, the save file is the only file being read from; do so before pleding and drop the "rpath" promise all together: log files will only be created and written to. 2021-06-11Match gemini URLsJune McEnroe 2021-06-10Avoid trailing comma in whois channels listsJune McEnroe The format of the reply is defined as "<nick> :{[@|+]<channel><space>}". 2021-06-10Move unveilAll back into mainJune McEnroe It doesn't do as much anymore, so move it back inline. 2021-06-10Only explicitly load the default CA file on OpenBSDJune McEnroe 2021-06-10OpenBSD: Drop now unneeded promise from initial pledgeKlemens Nanni Both ssl(8) as well as ncurses(3) related files are now read completely by the time of ircConfig() and uiInitEarly() respectively, so read access to the filesystem is no longer needed at all unless the "log" or "save" options are used. 2021-06-10OpenBSD: Remove now obsolete unveil codeKlemens Nanni Previous tls_default_ca_cert_file(3) hoisting makes this possible: all TLS related files are fully loaded into memory by ircConfig() such that ircConnect() will not do any file I/O. Call ircConfig() before pledge(2) in the `-o' "print cert" case so this works out -- that order should have been preserved in the previous a989e15 "OpenBSD: hoist -o/printCert code to simplify" but fixing it now nicely demonstrates the achivement even more so. 2021-06-10Hoist loading default root certificates into ircConfig()Klemens Nanni tls_connect_socket(3) in ircConnect() does that by default already unless tls_config_set_ca_file(3) was used. Loading CA certificates before connecting makes no practical difference except on OpenBSD where this allows for tighter unveil und pledge setups now that all required (TLS related) file I/O is finished by the time ircConnect() gets to do network I/O. In case of the hidden `-!' insecure flag which is implied by `-o' to print server certificates and exit, loading root certificates is not required at all; likewise, using explicit self signed server certificates will not involve certificate authorities either, hence load them only if needed. 2021-06-09Avoid creating out-of-bounds pointer when checking for seprintf truncationMichael Forney It is technically undefined behavior (see C11 6.5.6p8) to construct a pointer more than one past the end of an array. To prevent this, compare n with the remaining space in the array before adding to ptr. 2021-06-09Remove catfJune McEnroe 2021-06-09Replace catf with seprintf