diff options
| author | June McEnroe <june@causal.agency> | 2020-12-23 14:19:58 -0500 |
|---|---|---|
| committer | June McEnroe <june@causal.agency> | 2020-12-23 15:56:18 -0500 |
| commit | 4e5215cb6185108ade86af49f123b13674fe9587 (patch) | |
| tree | 0157b48b88af880c20646a7a1d975c0933dea720 /www/text.causal.agency/006-some-libs.7 | |
| parent | Bind libedit's secret filename completion function (diff) | |
| download | src-4e5215cb6185108ade86af49f123b13674fe9587.tar.gz src-4e5215cb6185108ade86af49f123b13674fe9587.zip | |
Cache the expanded prompt for editline
Previously, the prompt would be expanded every time editline called the getprompt callback. I think the code may have been written assuming that editline only calls getprompt once per prompt, but it may actually call it many times, for instance every time you type backspace. This results not only in slower editing from expanding complex prompts repeatedly, it also consumes more and more stack memory each time getprompt is called. This can be seen by setting PS1 to some command substitution, typing many characters at the prompt, then holding backspace and observing memory usage. Thankfully all this stack memory is freed between prompts by the stackmark calls around el_gets. This change causes prompt expansion to always happen in the setprompt call, as it would when editline is disabled, and a cached copy of the prompt is saved for getprompt to return every time editline calls it. Since getprompt is no longer doing expansion, the stackmark calls surrounding el_gets can be removed.
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions