summary refs log tree commit diff
Commit message (Expand)AuthorAge
...
* Document lack of window size propagationJune McEnroe2019-07-08
* Add pteeJune McEnroe2019-07-08
* Add Wild SeedJune McEnroe2019-07-08
* Add common includes to AGPL templateJune McEnroe2019-07-06
* Remove redundant includeJune McEnroe2019-07-06
* Add CSS output to schemeJune McEnroe2019-07-06
* Add diff syntax to hiJune McEnroe2019-07-01
* Use env.sh as 1sh todo listJune McEnroe2019-07-01
* Clean up 1sh prompt settingJune McEnroe2019-06-29
* Add Parable of the TalentsJune McEnroe2019-06-29
* Rename catsh to 1shJune McEnroe2019-06-28
* Set HISTSIZE in catshJune McEnroe2019-06-28
* Unset iflag when exiting catshJune McEnroe2019-06-28
* Consolidate catsh history documentationJune McEnroe2019-06-24
* Set LESS=FRXJune McEnroe2019-06-19
* Alias date=ddateJune McEnroe2019-06-16
* Set sensitivity by slot in TF2June McEnroe2019-06-15
* Add AcceptanceJune McEnroe2019-06-15
* Add variables to bitJune McEnroe2019-06-07
* Add A Closed and Common OrbitJune McEnroe2019-06-05
* Add RebornJune McEnroe2019-06-02
* Add bit to bin.7June McEnroe2019-05-30
* Simplify and build bitJune McEnroe2019-05-30
* Add xx -p optionJune McEnroe2019-05-29
* Add FrontierJune McEnroe2019-05-27
* Break nicks with ZWNJJune McEnroe2019-05-27
* Add DawnJune McEnroe2019-05-26
* Declare vasprintf(3) for GNUJune McEnroe2019-05-20
* Fix comparison warning in ttpreJune McEnroe2019-05-20
* Add AuthorityJune McEnroe2019-05-20
* Specify precedence of unary versions of operatorsJune McEnroe2019-05-19
* Add compound assignment operators to orderJune McEnroe2019-05-18
* Support simple assignment in orderJune McEnroe2019-05-15
* Implement sizeof in orderJune McEnroe2019-05-15
* Add orderJune McEnroe2019-05-15
* Add T suffix in bitJune McEnroe2019-05-12
* Highlight yacc and lex files as CJune McEnroe2019-05-10
* Use val instead of suboptargJune McEnroe2019-05-10
* Add Parable of the SowerJune McEnroe2019-05-09
* Add bit without buildJune McEnroe2019-05-07
* Fix MANDIR typoJune McEnroe2019-05-04
* Move relay to binJune McEnroe2019-05-04
* Add relay.1June McEnroe2019-04-28
* Use capsicum in irc/relayJune McEnroe2019-04-27
* Add missing includeJune McEnroe2019-04-27
* Add IRC relay botJune McEnroe2019-04-27
* Add LightlessJune McEnroe2019-04-25
* Set PS1 to \$ by defaultJune McEnroe2019-04-19
* Simplify ENV default value in catsh.1June McEnroe2019-04-19
* Factor out XDG_CONFIG_HOME and XDG_DATA_HOMEJune McEnroe2019-04-18
generated by cgit-pink 1.4.1 (git 2.36.1) at 2026-10-25 15:03:49 +0000
was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu