summary refs log tree commit diff
Commit message (Expand)AuthorAge
...
* Use ellipsis in promptJune McEnroe2013-12-08
* Add heroku aliasesJune McEnroe2013-11-26
* Only set title in xtermJune McEnroe2013-11-18
* Remove useless syntastic optionJune McEnroe2013-11-11
* Revert "Reorganize vimrc (again)"June McEnroe2013-11-10
* Remove unused Q vim bindingJune McEnroe2013-11-10
* Reorganize vimrc (again)June McEnroe2013-11-10
* Switch to effuse.yml for Effuse 2.1June McEnroe2013-11-10
* Replace vim-autoclose with auto-pairsJune McEnroe2013-11-10
* Add vim-autocloseJune McEnroe2013-11-10
* Set scrolloff=1June McEnroe2013-11-10
* Add vim-endwiseJune McEnroe2013-11-10
* Add vim-surroundJune McEnroe2013-11-10
* Add list of configurationsJune McEnroe2013-11-10
* Effuse ignore vim-plug.shJune McEnroe2013-11-10
* Remove useless dotvim ignoresJune McEnroe2013-11-10
* Merge in programble/dotvimJune McEnroe2013-11-10
|\
| * Remove instructions from READMEJune McEnroe2013-11-09
| * Fix NumberToggleJune McEnroe2013-11-09
| * Add Plugins commentJune McEnroe2013-11-09
| * Switch to vim-plugJune McEnroe2013-11-09
| * Add vim-easy-alignJune McEnroe2013-11-09
| * Remove unused plugin configurationsJune McEnroe2013-11-09
| * Update jellybeansJune McEnroe2013-11-03
| * Add bindings for CtrlPBufTag and CtrlPLineJune McEnroe2013-11-03
| * Update pluginsJune McEnroe2013-11-03
| * Remove unused pluginsJune McEnroe2013-11-03
| * Update jellybeansJune McEnroe2013-11-03
| * Switch to (customized) jellybeans colorschemeJune McEnroe2013-11-03
| * Disable Airline whitespace extensionJune McEnroe2013-11-03
| * Replace vim-gitgutter with vim-signifyJune McEnroe2013-11-02
| * Add tagbarJune McEnroe2013-11-02
| * Add AirlineJune McEnroe2013-11-02
| * Remove powerlineJune McEnroe2013-11-02
| * Disable some options in terminalsJune McEnroe2013-09-06
| * Only set colorscheme for gvimJune McEnroe2013-09-05
| * Add vim-ragtagJune McEnroe2013-08-17
| * Update base16-vimJune McEnroe2013-06-08
| * Switch to my own fork of base16-vimJune McEnroe2013-06-07
| * Indent compojure correctlyJune McEnroe2013-05-24
| * Remove vim-clojure-staticJune McEnroe2013-05-23
| * Replace VimClojure with vim-clojure-staticJune McEnroe2013-05-23
| * Do not run gitgutter eagerlyJune McEnroe2013-05-18
| * Remove tabularJune McEnroe2013-05-15
| * Use long names for all settingsJune McEnroe2013-05-15
| * Add vim-gitgutterJune McEnroe2013-05-15
| * Remove unused pluginsJune McEnroe2013-04-23
| * Switch to base16-default colorschemeJune McEnroe2013-04-23
| * Replace nerdcommenter with vim-commentaryJune McEnroe2013-03-26
| * Add paredit.vimJune McEnroe2013-03-24
generated by cgit-pink 1.4.1 (git 2.36.1) at 2026-09-20 19:17:42 +0000
icular, we need to test for GLOB_NOMAGIC | GLOB_NOCHECK instead of GLOB_MAGCHAR. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix buffer overflow in expandmetaHerbert Xu The native version of expandmeta allocates a buffer that may be overrun for two reasons. First of all the size is 1 byte too small but this is normally hidden because the minimum size is rounded up to 2048 bytes. Secondly, if the directory level is deep enough, any buffer can be overrun. This patch fixes both problems by calling realloc when necessary. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Move echo space/nl handling into print_escape_strHerbert Xu Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu