summary refs log tree commit diff
Commit message (Expand)AuthorAge
...
* Add option to default to text in hiJune McEnroe2019-12-15
* Match .profile and .shrc as shell in hiJune McEnroe2019-12-15
* Add Exit StrategyJune McEnroe2019-12-12
* Add a few more notes about librariesJune McEnroe2019-12-11
* Post "Some Libraries"June McEnroe2019-12-11
* Document diff input language in hiJune McEnroe2019-12-11
* Add Truth HurtsJune McEnroe2019-12-11
* Add Artificial ConditionJune McEnroe2019-12-08
* Allow cd-ing into a fileJune McEnroe2019-12-05
* Add The Fifth SeasonJune McEnroe2019-12-05
* Fix \? prompt expansion for more than one digitJune McEnroe2019-12-02
* Only add existing directories to PATHJune McEnroe2019-11-29
* Clear PATH before populating it againJune McEnroe2019-11-27
* Rename bin.7 to README.7June McEnroe2019-11-27
* Document HISTFILEJune McEnroe2019-11-26
* Update catgirl screenshotJune McEnroe2019-11-25
* Update shotty flagsJune McEnroe2019-11-25
* Replace shotty with code from streamJune McEnroe2019-11-25
* Add bman alias for FreeBSD man pagesJune McEnroe2019-11-22
* Remove Linux aliases from .shrcJune McEnroe2019-11-22
* Add Rogue ProtocolJune McEnroe2019-11-22
* Remove 1sh env.shJune McEnroe2019-11-21
* Use .profile, .shrc, .historyJune McEnroe2019-11-21
* Remove default ENV from manualJune McEnroe2019-11-21
* Do not apply expansion to HISTFILEJune McEnroe2019-11-21
* Revert "Set default ENV to ~/.config/cash/cashrc"June McEnroe2019-11-21
* Remove HISTFILE default valueJune McEnroe2019-11-21
* Remove vendored libeditJune McEnroe2019-11-21
* Revert "Use local libedit"June McEnroe2019-11-21
* Just use H_LOAD and H_SAVEJune McEnroe2019-11-21
* Use braces in 1sh MakefileJune McEnroe2019-11-21
* Add \? to promptJune McEnroe2019-11-20
* Add \? exit status prompt expansionJune McEnroe2019-11-20
* Remove PSlitJune McEnroe2019-11-20
* Remove color from 1sh promptsJune McEnroe2019-11-20
* Move pounce to top of causal.agencyJune McEnroe2019-11-19
* Add Ninefox GambitJune McEnroe2019-11-18
* Add The Great BelieversJune McEnroe2019-11-08
* Add GPL header templateJune McEnroe2019-11-06
* Add uber messageJune McEnroe2019-11-01
* Add Hobo Johnson and The Lovemakers Tiny DeskJune McEnroe2019-11-01
* Use braces in causal.agency MakefileJune McEnroe2019-10-30
* Add scheme "screenshot" to causal.agencyJune McEnroe2019-10-30
* Add pounce to causal.agencyJune McEnroe2019-10-30
* Mark ' for \aJune McEnroe2019-10-28
* Add The Book of the Unnamed MidwifeJune McEnroe2019-10-23
* Add ConcreteJune McEnroe2019-10-22
* Set the write variable for nvim man modeJune McEnroe2019-10-14
* Add All Systems RedJune McEnroe2019-10-13
* Add The Book of PhoenixJune McEnroe2019-10-10
generated by cgit-pink 1.4.1 (git 2.36.1) at 2026-06-23 01:43:08 +0000
utomake option was not supplied. I've just been adding it myself, but I finally got around to submitting a patch. The code still compiles for now (i'm using automake 1.15.1), but warning text is rarely nice to see and, if the warning text is to be believed, then the warning will eventually become an error. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19eval: Restore input files in evalcommandHerbert Xu When evalcommand invokes a command that modifies parsefile and then bails out without popping the file, we need to ensure the input file is restored so that the shell can continue to execute. Reported-by: Martijn Dekker <martijn@inlv.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19eval: Reap zombies after built-in commands and functionsHerbert Xu Currently dash does not reap dead children after built-in commands or functions. This means that if you construct a loop consisting of solely built-in commands and functions, then zombies can hang around indefinitely. This patch fixes this by reaping when necessary after each built-in command and function. Reported-by: Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19redir: Fix typo in noclobber codeHerbert Xu The noclobber code has a typo in it that causes it to fail. This patch fixes it. Reported-by: Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19expand: Fix glibc glob(3) supportHerbert Xu It's been a while since we disabled glob(3) support by default. It appears to be working now, however, we have to change our code to detect the no-match case correctly. In particular, we need to test for GLOB_NOMAGIC | GLOB_NOCHECK instead of GLOB_MAGCHAR. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix buffer overflow in expandmetaHerbert Xu The native version of expandmeta allocates a buffer that may be overrun for two reasons. First of all the size is 1 byte too small but this is normally hidden because the minimum size is rounded up to 2048 bytes. Secondly, if the directory level is deep enough, any buffer can be overrun. This patch fixes both problems by calling realloc when necessary. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Move echo space/nl handling into print_escape_strHerbert Xu Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu