summary refs log tree commit diff
Commit message (Expand)AuthorAge
...
* | | Adjust brightness by smaller incrementsJune McEnroe2021-02-07
* | | Fix cwm window cycling, move big by defaultJune McEnroe2021-02-07
* | | Use class names for Foreground, Background, BorderColorJune McEnroe2021-02-07
* | | Add simple battery status and clock to xsessionJune McEnroe2021-02-07
* | | Set cursor theme and sizeJune McEnroe2021-02-07
* | | Use scrot for up -s if no screencaptureJune McEnroe2021-02-07
* | | Enable mouse acceleration in XJune McEnroe2021-02-07
* | | Set colours for Xt and cwmJune McEnroe2021-02-07
* | | Set urgency on bell in xtermJune McEnroe2021-02-07
* | | Add bindings for brightness controlJune McEnroe2021-02-07
* | | Set X key repeat rateJune McEnroe2021-02-07
* | | Bump font size to 12June McEnroe2021-02-07
* | | Fully configure and rebind cwmJune McEnroe2021-02-07
* | | Add BintiJune McEnroe2021-02-07
* | | Finish configuring xtermJune McEnroe2021-02-07
* | | Enable tapping, reverse scroll, set scaling in wsconsctlJune McEnroe2021-02-06
* | | Set root window to black on purple snowJune McEnroe2021-02-06
* | | Add xmodmap configurationJune McEnroe2021-02-06
* | | Add initial OpenBSD X configurationJune McEnroe2021-02-06
* | | Add xterm output to schemeJune McEnroe2021-02-06
* | | Add wsconsctl.confJune McEnroe2021-02-06
* | | Add /usr/X11R6/bin to PATHJune McEnroe2021-02-06
* | | Add I Hope We Choose LoveJune McEnroe2021-02-05
* | | Use owner-filter to add Liberapay donation buttonsJune McEnroe2021-02-04
* | | Use owner-filter for repo page headersJune McEnroe2021-02-04
* | | Warn twice about stopped jobsJune McEnroe2021-02-04
* | | Remove cgit logo using cgitrcJune McEnroe2021-02-04
* | | Add The Rosewater RedemptionJune McEnroe2021-01-31
* | | Use int when checking for EOFJune McEnroe2021-01-29
* | | Move gpl.c and agpl.c templates out of etcJune McEnroe2021-01-28
* | | Set para and sect for mdocJune McEnroe2021-01-27
* | | Use First state to match keyword at beginning of lineJune McEnroe2021-01-26
* | | Install vi on Linux and nvi on macOSJune McEnroe2021-01-25
* | | Use vi and lessJune McEnroe2021-01-25
* | | Use mtags for sh in source-filterJune McEnroe2021-01-20
* | | Generate tags for sh files in mtagsJune McEnroe2021-01-20
* | | Add messy sh lexerJune McEnroe2021-01-20
* | | Add all target to git.causal.agency MakefileJune McEnroe2021-01-20
* | | Remove Lua supportJune McEnroe2021-01-20
* | | Fix tests for diff spansJune McEnroe2021-01-20
* | | Avoid matching ':' in make tagsJune McEnroe2021-01-20
* | | Prefer tag matches not preceded by [[:alnum:]]June McEnroe2021-01-19
* | | Escape \ and / in mtags search patternsJune McEnroe2021-01-19
* | | Use mtags in source-filterJune McEnroe2021-01-20
* | | Add mtags to generate tags for make and mdocJune McEnroe2021-01-19
* | | Map tags to IDs using only [[:alnum:]-._]June McEnroe2021-01-19
* | | Don't use a pager if reading standard inputJune McEnroe2021-01-19
* | | Support BSD make syntax and match *.amJune McEnroe2021-01-19
* | | Match tab following escaped newline in make assignmentsJune McEnroe2021-01-19
* | | Allow matching lexers using first input lineJune McEnroe2021-01-18
tual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu