summary refs log tree commit diff
path: root/bin (follow)
Commit message (Expand)AuthorAge
...
* Use inline style rather than <b>, <i>, <u>June McEnroe2019-07-11
* Factor out clearJune McEnroe2019-07-11
* Add bright option to shottyJune McEnroe2019-07-11
* Output <b>, <i>, <u> in shottyJune McEnroe2019-07-11
* Ignore SM and RMJune McEnroe2019-07-10
* Add shotty man page and build itJune McEnroe2019-07-09
* Add up -cJune McEnroe2019-07-09
* Add options for default colors to shottyJune McEnroe2019-07-09
* Use char literals consistentlyJune McEnroe2019-07-08
* Add initial version of shottyJune McEnroe2019-07-08
* Add ^S toggle to pteeJune McEnroe2019-07-08
* Document lack of window size propagationJune McEnroe2019-07-08
* Add pteeJune McEnroe2019-07-08
* Remove redundant includeJune McEnroe2019-07-06
* Add CSS output to schemeJune McEnroe2019-07-06
* Add diff syntax to hiJune McEnroe2019-07-01
* Rename catsh to 1shJune McEnroe2019-06-28
* Unset iflag when exiting catshJune McEnroe2019-06-28
* Consolidate catsh history documentationJune McEnroe2019-06-24
* Add variables to bitJune McEnroe2019-06-07
* Add bit to bin.7June McEnroe2019-05-30
* Simplify and build bitJune McEnroe2019-05-30
* Add xx -p optionJune McEnroe2019-05-29
* Break nicks with ZWNJJune McEnroe2019-05-27
* Declare vasprintf(3) for GNUJune McEnroe2019-05-20
* Fix comparison warning in ttpreJune McEnroe2019-05-20
* Specify precedence of unary versions of operatorsJune McEnroe2019-05-19
* Add compound assignment operators to orderJune McEnroe2019-05-18
* Support simple assignment in orderJune McEnroe2019-05-15
* Implement sizeof in orderJune McEnroe2019-05-15
* Add orderJune McEnroe2019-05-15
* Add T suffix in bitJune McEnroe2019-05-12
* Highlight yacc and lex files as CJune McEnroe2019-05-10
* Use val instead of suboptargJune McEnroe2019-05-10
* Add bit without buildJune McEnroe2019-05-07
* Fix MANDIR typoJune McEnroe2019-05-04
* Move relay to binJune McEnroe2019-05-04
* Add relay.1June McEnroe2019-04-28
* Use capsicum in irc/relayJune McEnroe2019-04-27
* Add missing includeJune McEnroe2019-04-27
* Add IRC relay botJune McEnroe2019-04-27
* Set PS1 to \$ by defaultJune McEnroe2019-04-19
* Simplify ENV default value in catsh.1June McEnroe2019-04-19
* Factor out XDG_CONFIG_HOME and XDG_DATA_HOMEJune McEnroe2019-04-18
* Rename cash to catshJune McEnroe2019-04-18
* Highlight line continuations in line commentsJune McEnroe2019-03-14
* Use getsubopt(3) to parse -o options in hiJune McEnroe2019-02-27
* Add type and ulimit shell keywordsJune McEnroe2019-02-27
* Fix make target pattern whitespace in hiJune McEnroe2019-02-27
* Delete extraneous <pre> in html.shJune McEnroe2019-02-27
generated by cgit-pink 1.4.1 (git 2.36.1) at 2026-10-23 21:08:12 +0000
0984b0aae69bba6f5034dc38aec1&follow=1'>eval: Reap zombies after built-in commands and functionsHerbert Xu Currently dash does not reap dead children after built-in commands or functions. This means that if you construct a loop consisting of solely built-in commands and functions, then zombies can hang around indefinitely. This patch fixes this by reaping when necessary after each built-in command and function. Reported-by: Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19redir: Fix typo in noclobber codeHerbert Xu The noclobber code has a typo in it that causes it to fail. This patch fixes it. Reported-by: Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19expand: Fix glibc glob(3) supportHerbert Xu It's been a while since we disabled glob(3) support by default. It appears to be working now, however, we have to change our code to detect the no-match case correctly. In particular, we need to test for GLOB_NOMAGIC | GLOB_NOCHECK instead of GLOB_MAGCHAR. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix buffer overflow in expandmetaHerbert Xu The native version of expandmeta allocates a buffer that may be overrun for two reasons. First of all the size is 1 byte too small but this is normally hidden because the minimum size is rounded up to 2048 bytes. Secondly, if the directory level is deep enough, any buffer can be overrun. This patch fixes both problems by calling realloc when necessary. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Move echo space/nl handling into print_escape_strHerbert Xu Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu