summary refs log tree commit diff
path: root/bin (follow)
Commit message (Expand)AuthorAge
...
* Fix gfxx row scrolling for BITS_TOTAL < 8June McEnroe2018-02-14
* Write at least 1 for each component of sBIT in gfxxJune McEnroe2018-02-14
* Write newlines between watch iterationsJune McEnroe2018-02-14
* Add gfxx DUMP_ALLJune McEnroe2018-02-14
* Replace pngChunk with glorious C metaprogrammingJune McEnroe2018-02-14
* Move PNG filename counter into gfxxJune McEnroe2018-02-14
* Remove typoJune McEnroe2018-02-14
* Unset dump in gfxx drawJune McEnroe2018-02-13
* Add PNG stream splitterJune McEnroe2018-02-13
* Dump gfxx screen to PNG on stdout with xJune McEnroe2018-02-12
* Add PNG encoder to gfxxJune McEnroe2018-02-12
* Add "Close Window" menu item to gfx/cocoaJune McEnroe2018-02-11
* Tweak gfxx code styleJune McEnroe2018-02-11
* Avoid xres/yres names in gfxxJune McEnroe2018-02-11
* Only set GFX if unsetJune McEnroe2018-02-11
* Link -lncursesJune McEnroe2018-02-09
* Fix X11 KeySym lookup with modifiersJune McEnroe2018-02-09
* Clean up bin/gfx/x11.cJune McEnroe2018-02-09
* Move gfx interface to header fileJune McEnroe2018-02-09
* Silence BSD ctags warningsJune McEnroe2018-02-09
* Link LDLIBS regardless of GFXJune McEnroe2018-02-09
* Move gfx frontends around to simplify buildJune McEnroe2018-02-09
* Add janky X11 graphics frontendJune McEnroe2018-02-07
* Include stdio.h in gfb.cJune McEnroe2018-02-07
* Exit by returning false from input to gf{b,cocoa}June McEnroe2018-02-07
* Rename title to status in gfcocoaJune McEnroe2018-02-07
* Require 4 bit counts on gfxx command lineJune McEnroe2018-02-06
* Add gfxx controls for custom bitsJune McEnroe2018-02-06
* Add gfxx palette loading and dumpingJune McEnroe2018-02-06
* Add tags targetJune McEnroe2018-02-06
* Replace gfxx SCALE macro with interp functionJune McEnroe2018-02-06
* Rename gfxx space indexed and add palette samplingJune McEnroe2018-02-05
* Take scale into account for when to stop drawing in gfxxJune McEnroe2018-02-05
* Always skip most significant bits in gfxxJune McEnroe2018-02-05
* Set title in gfcocoaJune McEnroe2018-02-05
* Double-buffer gfb frontendJune McEnroe2018-02-05
* Rewrite gfxx bit handlingJune McEnroe2018-02-05
* Add flip option to gfxxJune McEnroe2018-02-05
* Remove gfxx reverse optionJune McEnroe2018-02-05
* Fix gfxx draw stop conditionJune McEnroe2018-02-04
* Reuse CGColorSpace and CGDataProvider in gfcocoaJune McEnroe2018-02-04
* Mark mac target phonyJune McEnroe2018-02-04
* Set up Makefile for gfxx-cocoa or gfxx-fbJune McEnroe2018-02-04
* Avoid doing excessive work in gfxxJune McEnroe2018-02-04
* Handle window resizing in gfcocoaJune McEnroe2018-02-04
* Add palette sampling to gfxxJune McEnroe2018-02-04
* Add 4-bit RGB to gfxxJune McEnroe2018-02-04
* Add Quit menu item to gfcocoaJune McEnroe2018-02-04
* Switch back to sane Objective-C styleJune McEnroe2018-02-04
* Quit gfcocoa when window closesJune McEnroe2018-02-04
generated by cgit-pink 1.4.1 (git 2.36.1) at 2026-10-01 06:35:20 +0000
Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu