about summary refs log tree commit diff homepage
Commit message (Expand)AuthorAge
* Link with -lmJune McEnroe2018-07-22
* Add map to clientJune McEnroe2018-07-22
* Refactor readInput for each modeJune McEnroe2018-07-21
* Add ARRAY_LEN macroJune McEnroe2018-07-19
* Add server map generationJune McEnroe2018-07-17
* Tabify sourceJune McEnroe2018-07-17
* Fix ncurses color pair numberingJune McEnroe2018-05-13
* Use anonymous unionJune McEnroe2018-04-09
* Replace #define with enum or const where possibleJune McEnroe2018-04-09
* Link against ncursesJune McEnroe2018-03-31
* Miscellaneous code cleanupJune McEnroe2018-03-05
* Pass message structs by valueJune McEnroe2018-03-05
* Use stdio in merge and metaJune McEnroe2018-03-05
* Clean up spawn constantsJune McEnroe2018-03-05
* Rename Tile timestamps {create,modify,access}TimeJune McEnroe2018-03-05
* Pack message type enumsJune McEnroe2018-03-05
* Undef COLOR_ constants in torus.hJune McEnroe2018-03-05
* Generate tagsJune McEnroe2018-03-05
* Simplify Makefile with pattern ruleJune McEnroe2017-10-03
* Remove leading blank linesJune McEnroe2017-09-27
* Add merge.c to READMEJune McEnroe2017-09-27
* Assert client coords are valid after movementJune McEnroe2017-09-03
* Relicense AGPLJune McEnroe2017-09-03
* Revert "Add client readOnly mode"June McEnroe2017-09-01
* Remove clientRemove call from clientCastJune McEnroe2017-09-01
* Add client readOnly modeJune McEnroe2017-09-01
* Clean up merge toolJune McEnroe2017-08-31
* Choose B for tiles with equal modify timesJune McEnroe2017-08-31
* Add quick data file merge toolJune McEnroe2017-08-31
* Use only foreground color for selecting spawnJune McEnroe2017-08-30
* Add four additional spawnsJune McEnroe2017-08-29
* Add respawningJune McEnroe2017-08-28
* Move license above includesJune McEnroe2017-08-26
* Snapshot metadataJune McEnroe2017-08-26
* Add meta.c to READMEJune McEnroe2017-08-26
* Use MakefileJune McEnroe2017-08-26
* Add MakefileJune McEnroe2017-08-26
* Add metadata to CSV scriptJune McEnroe2017-08-26
* Add license to torus.h as wellJune McEnroe2017-08-24
* Add license to C filesJune McEnroe2017-08-24
* Add nethack to index.htmlJune McEnroe2017-08-21
* Clean up unnecessary kevent initializersJune McEnroe2017-08-13
* Check COLOR_PAIRS in clientJune McEnroe2017-08-08
* Patch termcap of rxvt-256color as wellJune McEnroe2017-08-08
* Add put modeJune McEnroe2017-08-08
* Remove MADV_NOSYNCJune McEnroe2017-08-08
* Completely retry if a send fails during a broadcastJune McEnroe2017-08-08
* Reverse order of main loopJune McEnroe2017-08-08
* Turn off SIGPIPE at the socket levelJune McEnroe2017-08-08
* Rewrite helpJune McEnroe2017-08-06
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-26 13:09:21 +0000
ss='logheader'>2018-04-02builtin: Move echo space/nl handling into print_escape_strHerbert Xu Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu