summary refs log tree commit diff homepage
path: root/2016
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2020-12-16 00:40:20 -0500
committerJune McEnroe <june@causal.agency>2020-12-16 00:40:20 -0500
commit65582ea0e9d23b4ddacf3fd19a12c5a7869e0831 (patch)
tree21c16ecd61212f2d59fe79cd8eed20b5c0503182 /2016
parentUpdate day 14 part 2 with the clever way (diff)
downloadaoc-65582ea0e9d23b4ddacf3fd19a12c5a7869e0831.tar.gz
aoc-65582ea0e9d23b4ddacf3fd19a12c5a7869e0831.zip
Solve day 16 part 1
Oh god I barely know what I'm doing in perl.
Diffstat (limited to '2016')
0 files changed, 0 insertions, 0 deletions
 

generated by cgit-pink 1.4.1 (git 2.36.1) at 2026-08-06 23:14:43 +0000


 


='logheader'>2014-10-08[EXPAND] Do not split quoted VSLENGTH and VSTRIMHerbert Xu

Currently VSLENGTH and VSTRIM* are field-split even within quotes.
This is obviously wrong.  This patch fixes that.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-10-08[EXPAND] Split unquoted $@/$* correctly when IFS is set but emptyHerbert Xu

Currently we do not field-split $@/$* when it isn't quoted and IFS
is set but empty.  This is obviously wrong.  This patch fixes this.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-10-07[VAR] Use setvareq to set OPTIND initiallyHerbert Xu

There is no need to setvarint to set the initial value of OPTIND
of one.  This patch switchs to setvareq which also lets us avoid
an unnecessary memory allocation.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-10-06[BUILTIN] Return without arguments in a trap should use status outside trapsHerbert Xu

POSIX now requires that return without arguments in a trap should
return the last command status prior to executing traps.  This
patch implements this behaviour.

Incidentally this also changes the behaviour of return without
arguments in a loop conditional to use the last exit status in
the body as opposed to the last command in the conditional when
there is one.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-10-06[BUILTIN] Allow return in loop conditional to set exit statusHerbert Xu

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=332954

When return is used in a loop conditional the exit status will
be lost because we always set the exit status at the end of the
loop to that of the last command executed in the body.

This is counterintuitive and contrary to what most other shells do.

This patch fixes this by always preserving the exit status of
return when it is used in a loop conditional.

The patch was originally written by Gerrit Pape <pape@smarden.org>.

Reported-by: Stephane Chazelas <stephane_chazelas@yahoo.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-10-06[EVAL] Move common skipcount logic into skiploopHerbert Xu

The functions evalloop and evalfor share the logic on checking
and updating skipcount.  This patch moves that into the helper
function skiploop.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-10-06[BUILTIN] Do not allow break to break across function callsHerbert Xu

As it is if you do a multi-level break inside a function it'll
actually include loops outside of the function call.  This is
counterintuitive.

This patch changes this by saving and resetting loopnest when
entering a function.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-10-06[BUILTIN] Exit without arguments in a trap should use status outside trapsHerbert Xu

POSIX now requires that exit without arguments in a trap should
return the last command status prior to executing traps.  This
patch implements this behaviour.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-10-03[EVAL] Do not clobber exitstatus in evalcommandHerbert Xu

All originators of EXERROR have been setting the exitstatus for
a while now.  So it is no longer appropriate to set it explicitly
in evalcommand.

In fact doing so may cause the original exitstatus to be lost.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-10-02[ERROR] Set exitstatus in onintHerbert Xu

Currently the exit status when we receive SIGINT is set in evalcommand
which means that it doesn't always get set.  For example, if you press
CTRL-C at the prompt of an interactive dash, the exit status is not
set to 130 as it is in many other Bourne shells.

This patch fixes this by moving the setting of the exit status into
onint which also simplifies evalcommand.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-10-02[TRAP] Make sure evalskip is zero before running trapsHerbert Xu

As it is if dotrap is called with evalskip set to a nonzero value,
it'll try to execute any set traps.  The result is that the first
command in the first set trap will be executed while the rest of
the trap will be silently ignored due to evalskip.  This is highly
counterintuitive, even though both bash and ksh exhibit a similar
behaviour.

This patch fixes it by skipping trap processing if evalskip is set
on entry.  It also adds a dotrap call to the top of evaltree to
ensure that

	while continue; do
		continue;
	done

has a chance of running traps.

Finally the pendingsigs check is moved into dotrap for compactness.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-10-02[EVAL] Fix use-after-free in dotrap/evalstringHerbert Xu

The function dotrap calls evalstring using the stored trap string.
If evalstring then unsets that exact trap string then we will end
up using freed memory.

This patch fixes it by making evalstring always duplicate the string
before using it.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-09-29[PARSER] Add nlprompt/nlnoprompt helpersHerbert Xu

This patch adds the nlprompt/nlnoprompt helpers to isolate code
dealing with newlines and prompting.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-09-29[PARSER] Handle backslash newlines properly after dollar signHerbert Xu

On Tue, Aug 26, 2014 at 12:34:42PM +0000, Eric Blake wrote:
> On 08/26/2014 06:15 AM, Oleg Bulatov wrote:
> > Hi!
> > 
> > While playing with sh generators I found that dash and bash have different
> > interpretations for <slash><newline> sequence.
> > 
> > $ dash -c 'EDIT=xxx; echo $EDIT\
> >> OR'
> > xxxOR
> 
> Buggy.
> 
> > $ bash -c 'EDIT=xxx; echo $EDIT\
> > OR'
> > /usr/bin/vim
> 
> Correct behavior.
> 
> > 
> > $ dash -c 'echo "$\
> > (pwd)"'
> > $(pwd)
> > 
> > Is it undefined behaviour in POSIX?
> 
> No, it's well-defined, and dash is buggy.  POSIX says:
> 
> http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_03
> 
> "the shell shall break its input into tokens by applying the first
> applicable rule below to the next character in its input"
> 
> Rule 4 covers backslash handling, while rule 5 covers locating the end
> of a word to be subject to $ expansion.  Therefore, rule 4 should happen
> first.  Rule 4 defers to the section on quoting, with the caveat that
> <newline> joining is the only substitution that happens immediately as
> part of the parsing:
> 
> http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_02
> 
> "If a <newline> follows the <backslash>, the shell shall interpret this
> as line continuation. The <backslash> and <newline> shall be removed
> before splitting the input into tokens. Since the escaped <newline> is
> removed entirely from the input and is not replaced by any white space,
> it cannot serve as a token separator."
> 
> So the fact that dash is treating the elided backslash-newline as a
> token separator, and parsing your input as if ${EDIT}OR instead of
> ${EDITOR} is a bug in dash.

I agree.  This patch should resolve this problem and similar ones
affecting blackslash newlines after we encounter a dollar sign.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



2014-09-29[INPUT] Kill pgetc_macro