summary refs log tree commit diff
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2018-12-04 15:56:10 -0500
committerJune McEnroe <june@causal.agency>2018-12-04 15:56:10 -0500
commit638be4e7757a7e7fcb52332461b5b1b5330a6771 (patch)
tree14190aec10060e1d8b9a3af6bc95b56781590cda
parentSend only SIGHUP in sandman (diff)
downloadcatgirl-638be4e7757a7e7fcb52332461b5b1b5330a6771.tar.gz
catgirl-638be4e7757a7e7fcb52332461b5b1b5330a6771.zip
Show error if disconnected unintentionally
-rw-r--r--chat.h1
-rw-r--r--event.c6
-rw-r--r--handle.c13
-rw-r--r--input.c1
4 files changed, 15 insertions, 6 deletions
diff --git a/chat.h b/chat.h
index 01dcd72..9a544f5 100644
--- a/chat.h
+++ b/chat.h
@@ -44,6 +44,7 @@ struct {
 	char *join;
 	bool verbose;
 	bool notify;
+	bool quit;
 } self;
 
 void eventWait(const char *argv[static 2]);
diff --git a/event.c b/event.c
index 4ea9f81..a5a49cc 100644
--- a/event.c
+++ b/event.c
@@ -131,10 +131,14 @@ noreturn void eventLoop(void) {
 
 	for (;;) {
 		if (sig[SIGCHLD]) childWait();
-		if (sig[SIGHUP]) ircFmt("QUIT :zzz\r\n");
+		if (sig[SIGHUP]) {
+			ircFmt("QUIT :zzz\r\n");
+			self.quit = true;
+		}
 		if (sig[SIGINT]) {
 			signal(SIGINT, SIG_DFL);
 			ircFmt("QUIT :Goodbye\r\n");
+			self.quit = true;
 		}
 		if (sig[SIGWINCH]) {
 			curses.sa_handler(SIGWINCH);
diff --git a/handle.c b/handle.c
index 137f859..3b52f0c 100644
--- a/handle.c
+++ b/handle.c
@@ -95,11 +95,14 @@ static void handlePing(char *prefix, char *params) {
 }
 
 static void handleError(char *prefix, char *params) {
-	(void)prefix;
-	(void)params;
-	// TODO: Show error if unintended disconnect.
-	uiExit();
-	exit(EX_OK);
+	char *mesg;
+	parse(prefix, NULL, NULL, NULL, params, 1, 0, &mesg);
+	if (self.quit) {
+		uiExit();
+		exit(EX_OK);
+	} else {
+		errx(EX_PROTOCOL, "%s", mesg);
+	}
 }
 
 static void handleErrorErroneousNickname(char *prefix, char *params) {
diff --git a/input.c b/input.c
index cc52928..7093363 100644
--- a/input.c
+++ b/input.c
@@ -106,6 +106,7 @@ static void inputTopic(struct Tag tag, char *params) {
 static void inputQuit(struct Tag tag, char *params) {
 	(void)tag;
 	ircFmt("QUIT :%s\r\n", params ? params : "Goodbye");
+	self.quit = true;
 }
 
 static void inputURL(struct Tag tag, char *params) {
nfeld Since tail is initialized to 0, we will never get a warning on the last if statement, but recent gcc complains anyway. So, we initialize len as well. Future gcc versions should be able to optimize this out anyway. 2013-03-20cgit.mk: Use SHELL_PATH_SQ to run gen-version.shJohn Keeping On some platforms (notably Solaris) /bin/sh doesn't support enough of POSIX for gen-version.sh to run. Git's Makefile provides SHELL_PATH_SQ to address this issue so we just have to use it. Signed-off-by: John Keeping <john@keeping.me.uk> 2013-03-20cgit.mk: don't rebuild everything if CGIT_VERSION changesJohn Keeping If CGIT_VERSION is in CGIT_CFLAGS then a change in version (for example because you have committed your changes) causes all of the CGit objects to be rebuilt. Avoid this by using EXTRA_CPPFLAGS to add the version for only those files that are affected and make them depend on VERSION. Signed-off-by: John Keeping <john@keeping.me.uk> 2013-03-20ui-patch: use cgit_version not CGIT_VERSIONJohn Keeping We already have a global cgit_version which is set from the #define'd CGIT_VERSION in cgit.c. Change ui-patch.c to use this so that we only need to rebuild cgit.o when the version changes. Signed-off-by: John Keeping <john@keeping.me.uk> 2013-03-20Makefile: re-use Git's Makefile where possibleJohn Keeping