summary refs log tree commit diff
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2020-02-17 11:49:56 -0500
committerJune McEnroe <june@causal.agency>2020-02-17 11:49:56 -0500
commitfa29c3791119d9fafac1509d43e8da22c31cda6d (patch)
tree0da2ff38171ce93a286b20db7df5b36f741d9738
parentVarious small cleanups (diff)
downloadcatgirl-fa29c3791119d9fafac1509d43e8da22c31cda6d.tar.gz
catgirl-fa29c3791119d9fafac1509d43e8da22c31cda6d.zip
Scroll the window only once during reflow
ncurses implements scrolling as a memmove of the array of lines
pointers, which happens each time a line is added to the bottom of the
window, causing a scroll. This would get noticeably slow if WindowLines
were increased to just 1024. Should've used a ring buffer, I think.
-rw-r--r--ui.c11
1 files changed, 7 insertions, 4 deletions
diff --git a/ui.c b/ui.c
index bcb1003..938eda6 100644
--- a/ui.c
+++ b/ui.c
@@ -621,18 +621,21 @@ void uiFormat(
 
 static void reflow(struct Window *window) {
 	werase(window->pad);
-	wmove(window->pad, WindowLines - 1, 0);
+	wmove(window->pad, 0, 0);
+	int flowed = 0;
 	window->unreadLines = 0;
 	for (size_t i = 0; i < BufferCap; ++i) {
 		const char *line = bufferLine(&window->buffer, i);
 		if (!line) continue;
 		waddch(window->pad, '\n');
+		int lines = 1 + wordWrap(window->pad, line);
 		if (i >= (size_t)(BufferCap - window->unreadTotal)) {
-			window->unreadLines += 1 + wordWrap(window->pad, line);
-		} else {
-			wordWrap(window->pad, line);
+			window->unreadLines += lines;
 		}
+		flowed += lines;
 	}
+	wscrl(window->pad, -(WindowLines - 1 - flowed));
+	wmove(window->pad, WindowLines - 1, RIGHT);
 }
 
 static void resize(void) {
2015-08-14ui-shared: add cgit_print_error_page() functionJohn Keeping 2015-08-14ui-patch: make sure to send http headersChristian Hesse 2015-08-13Makefile: make "git/config.mak.uname" inclusion optionalJohn Keeping 2015-08-13ui-shared: show full date in tooltip if longer ago than max_relativeJohn Keeping 2015-08-13ui-shared: use common function in print_rel_date()John Keeping 2015-08-13ui-shared: extract date formatting to a functionJohn Keeping 2015-08-13filter: don't use dlsym unnecessarilyJohn Keeping 2015-08-13ui-tree: use "sane" isgraph()John Keeping 2015-08-13cgit.h: move stdbool.h from ui-shared.hJohn Keeping 2015-08-13cache.c: fix header orderJohn Keeping 2015-08-13configfile.c: don't include system headers directlyJohn Keeping 2015-08-13Remove redundant includesJohn Keeping 2015-08-13Makefile: include Git's config.mak.unameJohn Keeping 2015-08-13tests: allow shell to be overriddenJohn Keeping 2015-08-13redirect: cleanlinessJason A. Donenfeld 2015-08-13redirect: be more careful for different cgi setupsJason A. Donenfeld 2015-08-12ui-log: fix double countingJohn Keeping 2015-08-12log: allow users to follow a fileJohn Keeping 2015-08-12shared: make cgit_diff_tree_cb publicJohn Keeping 2015-08-12t0110: Chain together using &&Jason A. Donenfeld 2015-08-12about: always ensure page has a trailing slashJason A. Donenfeld 2015-08-12filters: apply HTML escapingLazaros Koromilas 2015-08-12git: update to v2.5.0Christian Hesse 2015-08-12Fix processing of repo.hide and repo.ignoreDaniel Reichelt