diff options
| author | Klemens Nanni <klemens@posteo.de> | 2021-06-11 12:30:58 +0000 |
|---|---|---|
| committer | June McEnroe <june@causal.agency> | 2021-06-11 20:57:40 -0400 |
| commit | cdd4ccf16ff6ccc202d3422fcd0ec7ca9f3a8229 (patch) | |
| tree | 3e8134723ecc031075b8ae8991ba2322518d4218 /Makefile | |
| parent | Rename file to saveFile (diff) | |
| download | catgirl-cdd4ccf16ff6ccc202d3422fcd0ec7ca9f3a8229.tar.gz catgirl-cdd4ccf16ff6ccc202d3422fcd0ec7ca9f3a8229.zip | |
Open save file once in uiLoad() and keep it open until uiSave()
Opening the same file *path* twice is a TOCTOU, although not a critical one: worst case we load from one file and save to another - the impact depends on how and when catgirl is started the next anyway. More importantly, keeping the file handle open at runtime allows us to drop all filesystem related promises for `-s/save' on OpenBSD. uiLoad() now opens "r+", meaning "Open for reading and writing." up front so uiSave() can write to it. In the case of a nonexistent save file, it now opens with "w" meaning "Open for writing. The file is created if it does not exist.", i.e. the same write/create semantics as "w" except uiLoad() no longer truncates. existing files. uiSave() now truncates the save file to avoid appending in general.
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions