summary refs log tree commit diff
path: root/Makefile
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2018-10-22 16:09:40 -0400
committerJune McEnroe <june@causal.agency>2018-10-22 16:09:40 -0400
commit35fdcbc285732029e17ff733d6f93f77b10c3707 (patch)
tree0b05c9293c8d600f8e435ea0d85c6352b18cd887 /Makefile
parentRename status and verbose tags (diff)
downloadcatgirl-35fdcbc285732029e17ff733d6f93f77b10c3707.tar.gz
catgirl-35fdcbc285732029e17ff733d6f93f77b10c3707.zip
Rework status line
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions
 

generated by cgit-pink 1.4.1 (git 2.36.1) at 2026-09-25 09:28:49 +0000


 


 Keeping

This stops the code in cgit.c::print_repo needing to inspect the
cgit_filter structure, meaning that we can abstract out different filter
types that will have different fields that need to be printed.

Signed-off-by: John Keeping <john@keeping.me.uk>



2014-01-14authors: specify maintainersJason A. Donenfeld

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>



2014-01-13filters: Improved syntax-highlighting.pyStefan Tatschner

- Switched back to python2 according to a problem in pygments with python3.
  With the next release of pygments this problem should be fixed.
  Issue see here:
  https://bitbucket.org/birkenfeld/pygments-main/issue/901/problems-with-python3
- Just read the stdin, decode it to utf-8 and ignore unknown signs. This ensures
  that even destroyed files do not cause any errors in the filter.
- Improved language guessing:
  -> At first use guess_lexer_for_filename for a better detection of the used
     programming languages (even mixed cases will be detected, e.g. php + html).
  -> If nothing was found look if there is a shebang and use guess_lexer.
  -> As default/fallback choose TextLexer.

Signed-off-by: Stefan Tatschner <stefan@sevenbyte.org>



2014-01-12tests: add CGIT_TEST_OPTS variable to MakefileJohn Keeping

This allows running the entire test suite with a set of command-line
options.  For example:

	make test CGIT_TEST_OPTS=--valgrind

Signed-off-by: John Keeping <john@keeping.me.uk>



2014-01-12ui-repolist: HTML-escape cgit_rooturl() responseJohn Keeping

This is for consistency with other callers.  The value returned from
cgit_rooturl is not guaranteed to be HTML-safe.

Signed-off-by: John Keeping <john@keeping.me.uk>



2014-01-12ui-shared: URL-escape script_nameJohn Keeping

As far as I know, there is no requirement that $SCRIPT_NAME contain only
URL-safe characters, so we need to make sure that any special characters
are escaped.

Signed-off-by: John Keeping <john@keeping.me.uk>



2014-01-12ui-refs: escape HTML chars in author and tagger namesJohn Keeping

Everywhere else we use html_txt to escape any special characters in
these variables.  Do so here as well.

Signed-off-by: John Keeping <john@keeping.me.uk>



2014-01-12filter: pass extra arguments via cgit_open_filterJohn Keeping

This avoids poking into the filter data structure at various points in
the code.  We rely on the fact that the number of arguments is fixed
based on the filter type (set in cgit_new_filter) and that the call
sites all know which filter type they're using.

Signed-off-by: John Keeping <john@keeping.me.uk>



2014-01-12ui-snapshot: set unused cgit_filter fields to zeroJohn Keeping

By switching the assignment of fields in the cgit_filter structure to
use designated initializers, the compiler will initialize all other
fields to their default value.  This will be needed when we add the
extra_args field in the next patch.

Signed-off-by: John Keeping <john@keeping.me.uk>



2014-01-12html: remove redundant htmlfd variableJohn Keeping

This is never changed from STDOUT_FILENO, so just use that value
directly.

Signed-off-by: John Keeping <john@keeping.me.uk>



2014-01-12tests: add Valgrind supportJohn Keeping

Now running tests with the "--valgrind" option will run cgit under
Valgrind instead of all Git commands.

Signed-off-by: John Keeping <john@keeping.me.uk>



2014-01-12cache: don't leave cache_slot fields uninitializedJohn Keeping

Valgrind says:

==18344== Conditional jump or move depends on uninitialised value(s)
==18344==    at 0x406C83: open_slot (cache.c:63)
==18344==    by 0x407478: cache_ls (cache.c:403)
==18344==    by 0x404C9A: process_request (cgit.c:639)
==18344==    by 0x406BD2: fill_slot (cache.c:190)
==18344==    by 0x4071A0: cache_process (cache.c:284)
==18344==    by 0x404461: main (cgit.c:952)
==18344==  Uninitialised value was created by a stack allocation
==18344==    at 0x40738B: cache_ls (cache.c:375)

This is caused by the keylen field being used to calculate whether or
not a slot is matched.  We never then check the value of this and the
length of data read depends on the key length read from the file so this
isn't dangerous, but it's nice to avoid branching based on uninitialized
data.

Signed-off-by: John Keeping <john@keeping.me.uk>



2014-01-10filter: split filter functions into their own fileJason A. Donenfeld

A first step for more interesting things.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>



2014-01-10filter: make exit status localJason A. Donenfeld

It's only used in one place, and not useful to have around since
close_filter will die() if exit_status isn't what it expects, anyway. So
this is best as just a local variable instead of as part of the struct.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>



2014-01-10parsing: fix header typoJason A. Donenfeld


2014-01-10cgit.c: Fix comment on bit mask hackLukas Fleischer

* Formatting and spelling fixes.

* A bit mask with the size of one byte only allows for storing 8 (not
  255!) different flags.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>



2014-01-10cgit.c: Use "else" for mutually exclusive branchesLukas Fleischer

When parsing command line arguments, no pair of command line options can
ever match simultaneously. Use "else if" blocks to reflect this. This
change improves both readability and speed.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>



2014-01-10ui-snapshot.c: Do not reinvent suffixcmp()Lukas Fleischer

Use suffixcmp() from Git instead of reimplementing it. This is a
preparation for moving to ends_with() in Git 1.8.6.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>



2014-01-10Refactor cgit_parse_snapshots_mask()Lukas Fleischer

Use Git string lists instead of str{spn,cspn,ncmp}() magic. This
significantly improves readability.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>



2014-01-10Disallow use of undocumented snapshot delimiters