summary refs log tree commit diff
path: root/configure
diff options
context:
space:
mode:
authorMichael Forney <mforney@mforney.org>2021-06-04 22:14:44 -0700
committerJune McEnroe <june@causal.agency>2021-06-05 13:23:23 -0400
commit8d7460859b9f4a74b4d8c19295de4f8d21117f2b (patch)
treeb43b2dcb6eeb86648e3277f03f6c09e628cc4113 /configure
parentList windows with /window (diff)
downloadcatgirl-8d7460859b9f4a74b4d8c19295de4f8d21117f2b.tar.gz
catgirl-8d7460859b9f4a74b4d8c19295de4f8d21117f2b.zip
Avoid writing past the end of the status bar
When waddnstr is called with a string that would extend past the
end of the window, the string is truncated, the cursor remains at
the last column, and ERR is returned. If this error is ignored and
the loop continues, the next call to waddnstr overwrites the character
at this column, resulting in a slight visual artifact. When the
window is too small to fit the full status line, it is effectively
truncated by one space on the right, since the string shown for
each channel begins with a space.  Additionally, if the last window
is the current window, the space is shown with a colored background.

To fix this, when waddnstr returns ERR, exit the loop in styleAdd()
early return -1 to propogate this error down to the caller.
Diffstat (limited to 'configure')
0 files changed, 0 insertions, 0 deletions
Without '&&' between operations, we will not detect if strace or cgit exit with an error status, which would cause a false positive test status in this case. Signed-off-by: John Keeping <john@keeping.me.uk> 2013-04-10cgit.c: Do not restore unset environment variablesLukas Fleischer getenv() returns a NULL pointer if the specified variable name cannot be found in the environment. However, some setenv() implementations crash if a NULL pointer is passed as second argument. Only restore variables that are not NULL. See commit d96d2c98ebc4c2d3765f5b35c4142e0e828a421b for a related patch. Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de> 2013-04-09t0107: Use `tar -z` for gzip'ed archivesLukas Fleischer