summary refs log tree commit diff
path: root/filter.c
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2021-01-23 16:15:39 -0500
committerJune McEnroe <june@causal.agency>2021-01-23 16:15:39 -0500
commit61bd4079a0e2cb3817892580461407c8d009338d (patch)
treef6607ad48790caf5763d22463cd08c3567dc5a1b /filter.c
parentFix /unignore command (diff)
downloadcatgirl-61bd4079a0e2cb3817892580461407c8d009338d.tar.gz
catgirl-61bd4079a0e2cb3817892580461407c8d009338d.zip
Preserve order of filters when removing
Filters should be kept in order since the first one that matches,
wins. This lets highlights or ignores take priority over each other,
if desired.
Diffstat (limited to 'filter.c')
-rw-r--r--filter.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/filter.c b/filter.c
index 2a7d564..a648d8b 100644
--- a/filter.c
+++ b/filter.c
@@ -74,7 +74,7 @@ bool filterRemove(struct Filter filter) {
 		if (filter.chan && strcasecmp(filters[i].chan, filter.chan)) continue;
 		if (filter.mesg && strcasecmp(filters[i].mesg, filter.mesg)) continue;
 		free(filters[i].mask);
-		filters[i] = filters[--len];
+		memmove(&filters[i], &filters[i + 1], sizeof(*filters) * --len);
 		filters[len] = (struct Filter) {0};
 		found = true;
 	}
mp;' between operations, we will not detect if strace or cgit exit with an error status, which would cause a false positive test status in this case. Signed-off-by: John Keeping <john@keeping.me.uk> 2013-04-10cgit.c: Do not restore unset environment variablesLukas Fleischer getenv() returns a NULL pointer if the specified variable name cannot be found in the environment. However, some setenv() implementations crash if a NULL pointer is passed as second argument. Only restore variables that are not NULL. See commit d96d2c98ebc4c2d3765f5b35c4142e0e828a421b for a related patch. Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de> 2013-04-09t0107: Use `tar -z` for gzip'ed archivesLukas Fleischer