about summary refs log tree commit diff
path: root/handle.c
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2018-08-10 12:45:37 -0400
committerJune McEnroe <june@causal.agency>2018-08-10 12:45:37 -0400
commitb740e937df159255e4a33375e9e3afd03dd5a49b (patch)
tree903d0848f947b211e0ef73e91d6f623fcc629544 /handle.c
parentRename chan to join (diff)
downloadcatgirl-b740e937df159255e4a33375e9e3afd03dd5a49b.tar.gz
catgirl-b740e937df159255e4a33375e9e3afd03dd5a49b.zip
Remove unnecessary va_end
va_end must be called before the function returns, but errx is noreturn.
Diffstat (limited to 'handle.c')
-rw-r--r--handle.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/handle.c b/handle.c
index 81a38f7..be41828 100644
--- a/handle.c
+++ b/handle.c
@@ -58,10 +58,7 @@ static void shift(
 	va_list ap;
 	va_start(ap, opt);
 	for (size_t i = 0; i < req; ++i) {
-		if (!params) {
-			va_end(ap);
-			errx(EX_PROTOCOL, "%zu params required, found %zu", req, i);
-		}
+		if (!params) errx(EX_PROTOCOL, "%zu params required, found %zu", req, i);
 		field = paramField(&params);
 		char **param = va_arg(ap, char **);
 		if (param) *param = field;
to psfedJune McEnroe 2019-01-14Check for NULL copy or undo buffers in psfedJune McEnroe 2019-01-14Add cash.7 READMEJune McEnroe 2019-01-14Document old=new argument of fc -sJune McEnroe 2019-01-14Allow replacing empty string with fc old=newJune McEnroe 2019-01-13Enable warnings in libeditJune McEnroe 2019-01-13Show full path in RPS1June McEnroe 2019-01-13Shorten $HOME to ~ in prompt expansionJune McEnroe 2019-01-13Document PSlitJune McEnroe 2019-01-13Document PS0June McEnroe 2019-01-13Set PS0 in cashJune McEnroe 2019-01-13Add PS0June McEnroe 2019-01-13Change default ENV from cashrc to env.shJune McEnroe 2019-01-13Use colours in cash promptsJune McEnroe 2019-01-12Set PSlit like NetBSD shJune McEnroe 2019-01-12Install gnupg2 from pkgsrc and symlink gpgJune McEnroe 2019-01-12Reference cash builtin man pages in cash.1 SEE ALSOJune McEnroe 2019-01-12Restore cash builtin man page datesJune McEnroe 2019-01-12Use local libeditJune McEnroe 2019-01-12Replace libedit MakefileJune McEnroe 2019-01-11Import /usr/src/lib/libedit from NetBSD 8.0June McEnroe 2019-01-11Add PSlit for prompt escapesJune McEnroe 2019-01-11Don't make depend automaticallyJune McEnroe