summary refs log tree commit diff
path: root/scripts
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2020-02-11 18:01:50 -0500
committerJune McEnroe <june@causal.agency>2020-02-11 18:01:50 -0500
commitc9590bab061fcaa3e11a94eea8c34026a6c7a880 (patch)
tree49f34bd8ee14183d099dd8cca987618bfdc2c085 /scripts
parentSet self.nick to * initially (diff)
downloadcatgirl-c9590bab061fcaa3e11a94eea8c34026a6c7a880.tar.gz
catgirl-c9590bab061fcaa3e11a94eea8c34026a6c7a880.zip
Use time_t for save signature
It's actually more likely to be 64-bit than size_t anyway, and it
eliminates some helper functions.

Also don't error when reading an empty save file.
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions
 

generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-14 19:52:48 +0000


 


 with the "--valgrind" option will run cgit under
Valgrind instead of all Git commands.

Signed-off-by: John Keeping <john@keeping.me.uk>



2014-01-12cache: don't leave cache_slot fields uninitializedJohn Keeping

Valgrind says:

==18344== Conditional jump or move depends on uninitialised value(s)
==18344==    at 0x406C83: open_slot (cache.c:63)
==18344==    by 0x407478: cache_ls (cache.c:403)
==18344==    by 0x404C9A: process_request (cgit.c:639)
==18344==    by 0x406BD2: fill_slot (cache.c:190)
==18344==    by 0x4071A0: cache_process (cache.c:284)
==18344==    by 0x404461: main (cgit.c:952)
==18344==  Uninitialised value was created by a stack allocation
==18344==    at 0x40738B: cache_ls (cache.c:375)

This is caused by the keylen field being used to calculate whether or
not a slot is matched.  We never then check the value of this and the
length of data read depends on the key length read from the file so this
isn't dangerous, but it's nice to avoid branching based on uninitialized
data.

Signed-off-by: John Keeping <john@keeping.me.uk>



2014-01-10filter: split filter functions into their own fileJason A. Donenfeld

A first step for more interesting things.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>



2014-01-10filter: make exit status localJason A. Donenfeld

It's only used in one place, and not useful to have around since
close_filter will die() if exit_status isn't what it expects, anyway. So
this is best as just a local variable instead of as part of the struct.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>



2014-01-10parsing: fix header typoJason A. Donenfeld


2014-01-10cgit.c: Fix comment on bit mask hackLukas Fleischer

* Formatting and spelling fixes.

* A bit mask with the size of one byte only allows for storing 8 (not
  255!) different flags.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>



2014-01-10cgit.c: Use "else" for mutually exclusive branchesLukas Fleischer

When parsing command line arguments, no pair of command line options can
ever match simultaneously. Use "else if" blocks to reflect this. This
change improves both readability and speed.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>



2014-01-10ui-snapshot.c: Do not reinvent suffixcmp()Lukas Fleischer

Use suffixcmp() from Git instead of reimplementing it. This is a
preparation for moving to ends_with() in Git 1.8.6.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>



2014-01-10Refactor cgit_parse_snapshots_mask()Lukas Fleischer

Use Git string lists instead of str{spn,cspn,ncmp}() magic. This
significantly improves readability.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>



2014-01-10Disallow use of undocumented snapshot delimitersLukas Fleischer

Since the introduction of selective snapshot format configuration in
dc3c9b5 (allow selective enabling of snapshots, 2007-07-21), we allowed
seven different delimiters for snapshot formats, while the documentation
has always been clear about spaces being the only valid delimiter:

    The value is a space-separated list of zero or more of the values
    "tar", "tar.gz", "tar.bz2", "tar.xz" and "zip".

Supporting the undocumented delimiters makes the code unnecessarily
complex. Remove them.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>



2014-01-10Replace most uses of strncmp() with prefixcmp()Lukas Fleischer

This is a preparation for replacing all prefix checks with either
strip_prefix() or starts_with() when Git 1.8.6 is released.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>



2014-01-09README: Fix dependenciesLukas Fleischer

* Remove the dependency on Git (which can be obtained automatically when
  building, using either the Git submodule or `make get-git`).

* Use proper upstream names of dependencies.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>



2014-01-08README: Spelling and formatting fixesLukas Fleischer

* Several small spelling and capitalization fixes.

* Use consistent and better-looking formatting that is compatible with
  AsciiDoc (and partly compatible with RST).

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>



2014-01-08Fix UTF-8 with syntax-highlighting.pyPřemysl Janouch

Previously the script tried to encode output from Pygments with
the ASCII codec, which failed.

Signed-off-by: Přemysl Janouch <p.janouch@gmail.com>



2014-01-08Add a suggestion to the manpagePřemysl Janouch

So that people wishing to use "enable-http-clone" don't have to find
out the correct settings on their own.

Signed-off-by: Přemysl Janouch <p.janouch@gmail.com>



2014-01-08Fix the example configurationPřemysl Janouch

"enable-git-clone" doesn't exist, replaced with "enable-http-clone".

Signed-off-by: Přemysl Janouch <p.janouch@gmail.com>



2014-01-08Fix about-formatting.shPřemysl Janouch

dash failed to parse the script.

Signed-off-by: Přemysl Janouch <p.janouch@gmail.com>



2014-01-08Fix some spelling errorsPřemysl Janouch

Signed-off-by: Přemysl Janouch <p.janouch@gmail.com>



2014-01-08filters: highlight.sh: add css comments for highlight 2.6 and 3.8Ferry Huberts