summary refs log tree commit diff
Commit message (Expand)AuthorAge
* Generate short option string with a loopJune McEnroe2020-04-02
* Do not add an extra blank line on uiLoadJune McEnroe2020-04-02
* Preserve the last blank line on reflowJune McEnroe2020-04-02
* Switch to windows with ascending unread counts on M-aJune McEnroe2020-04-02
* Mention running ldconfig after editing /etc/ld.so.confJune McEnroe2020-04-01
* Fix multi-mention tab completion conditionJune McEnroe2020-04-01
* Pass correct length to mbstowcsJune McEnroe2020-04-01
* Add note about building LibreSSL manuallyJune McEnroe2020-04-01
* Add \blushJune McEnroe2020-03-31
* Add notes on how to view README.7June McEnroe2020-03-31
* Add pounce to README's SEE ALSOJune McEnroe2020-03-31
* Update features listJune McEnroe2020-03-31
* Add join/part/quit filtering exampleJune McEnroe2020-03-31
* Hide filtered messagesJune McEnroe2020-03-31
* Add /ignore message filtering patternsJune McEnroe2020-03-31
* Save and load buffer line heatJune McEnroe2020-03-31
* Store line heat in bufferJune McEnroe2020-03-31
* Add \bear, \cool, \hug, \unflip, \waveJune McEnroe2020-03-31
* Replace int opt; while with for loop in sandmanJune McEnroe2020-03-31
* Replace some declaration; while loops with for loopsJune McEnroe2020-03-30
* Add text macrosJune McEnroe2020-03-30
* Tab complete from last iswspaceJune McEnroe2020-03-30
* Add /o alias for /openJune McEnroe2020-03-30
* Add /op, /deop, /voice, /devoiceJune McEnroe2020-03-29
* Rewrite mode formatting again and write to logJune McEnroe2020-03-28
* Log chat eventsJune McEnroe2020-03-25
* Add logging functionsJune McEnroe2020-03-25
* Track MODE in repliesJune McEnroe2020-03-23
* Fix non-multiline command newline handlingJune McEnroe2020-03-23
* Add M-Enter to insert a newlineJune McEnroe2020-03-23
* Handle bracketed paste, including newlinesJune McEnroe2020-03-23
* Allow commands to take multiline inputJune McEnroe2020-03-23
* Bump edit buffer cap to 1024June McEnroe2020-03-23
* Assume worst case for unknown user and host in splitMessageJune McEnroe2020-03-23
* Implement message splittingJune McEnroe2020-03-22
* Handle empty input directly in commandJune McEnroe2020-03-22
* Track own host, handle CHGHOSTJune McEnroe2020-03-22
* Add /sayJune McEnroe2020-03-22
* Handle RPL_CHANNELMODEISJune McEnroe2020-03-22
* Handle user mode changesJune McEnroe2020-03-22
* Rewrite handleModeJune McEnroe2020-03-22
* Handle RPL_UMODEISJune McEnroe2020-03-18
* Send blank line after 10 minutes idleJune McEnroe2020-03-17
* Ignore 422 ERR_NOMOTDJune McEnroe2020-03-09
* Set self.pos before handling the messageJune McEnroe2020-03-08
* Prevent entering commands in <debug> if restrictedJune McEnroe2020-03-02
* Implement the causal.agency/consumer capabilityJune McEnroe2020-02-29
* Add raw modes to mode messageJune McEnroe2020-02-25
* Handle changing setParamModes, paramModes and other channel modesJune McEnroe2020-02-25
* Fix handling EXCEPTS and INVEX without valuesJune McEnroe2020-02-25
generated by cgit-pink 1.4.1 (git 2.36.1) at 2025-11-16 12:52:03 +0000
he noclobber code has a typo in it that causes it to fail. This patch fixes it. Reported-by: Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19expand: Fix glibc glob(3) supportHerbert Xu It's been a while since we disabled glob(3) support by default. It appears to be working now, however, we have to change our code to detect the no-match case correctly. In particular, we need to test for GLOB_NOMAGIC | GLOB_NOCHECK instead of GLOB_MAGCHAR. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix buffer overflow in expandmetaHerbert Xu The native version of expandmeta allocates a buffer that may be overrun for two reasons. First of all the size is 1 byte too small but this is normally hidden because the minimum size is rounded up to 2048 bytes. Secondly, if the directory level is deep enough, any buffer can be overrun. This patch fixes both problems by calling realloc when necessary. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Move echo space/nl handling into print_escape_strHerbert Xu Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu