summary refs log tree commit diff
path: root/config.c (unfollow)
Commit message (Expand)Author
2020-03-29Add /op, /deop, /voice, /devoiceJune McEnroe
2020-03-28Rewrite mode formatting again and write to logJune McEnroe
2020-03-25Log chat eventsJune McEnroe
2020-03-25Add logging functionsJune McEnroe
2020-03-23Track MODE in repliesJune McEnroe
2020-03-23Fix non-multiline command newline handlingJune McEnroe
2020-03-23Add M-Enter to insert a newlineJune McEnroe
2020-03-23Handle bracketed paste, including newlinesJune McEnroe
2020-03-23Allow commands to take multiline inputJune McEnroe
2020-03-23Bump edit buffer cap to 1024June McEnroe
2020-03-23Assume worst case for unknown user and host in splitMessageJune McEnroe
2020-03-22Implement message splittingJune McEnroe
2020-03-22Handle empty input directly in commandJune McEnroe
2020-03-22Track own host, handle CHGHOSTJune McEnroe
2020-03-22Add /sayJune McEnroe
2020-03-22Handle RPL_CHANNELMODEISJune McEnroe
2020-03-22Handle user mode changesJune McEnroe
2020-03-22Rewrite handleModeJune McEnroe
2020-03-18Handle RPL_UMODEISJune McEnroe
2020-03-17Send blank line after 10 minutes idleJune McEnroe
2020-03-09Ignore 422 ERR_NOMOTDJune McEnroe
2020-03-08Set self.pos before handling the messageJune McEnroe
2020-03-02Prevent entering commands in <debug> if restrictedJune McEnroe
2020-02-29Implement the causal.agency/consumer capabilityJune McEnroe
2020-02-25Add raw modes to mode messageJune McEnroe
2020-02-25Handle changing setParamModes, paramModes and other channel modesJune McEnroe
2020-02-25Fix handling EXCEPTS and INVEX without valuesJune McEnroe
2020-02-25Add /mode, /except, /invex and handle lists repliesJune McEnroe
2020-02-23Accumulate mode changes into a buffer for one messageJune McEnroe
2020-02-20Handle ERR_CHANOPRIVSNEEDEDJune McEnroe
2020-02-20Handle MODE changing channel list modesJune McEnroe
2020-02-20Handle MODE setting channel prefix modesJune McEnroe
2020-02-20Just use "b" to query ban listJune McEnroe
2020-02-20Change ban list formattingJune McEnroe
2020-02-20Rearrange some handlersJune McEnroe
2020-02-20Handle RPL_INVITING when no invite-notifyJune McEnroe
2020-02-20Handle ERR_BANLISTFULLJune McEnroe
2020-02-20Add handlers for user-in-channel errorsJune McEnroe
2020-02-20Add generic error reply handlerJune McEnroe
2020-02-19Add /ban, /unban and handle ban list repliesJune McEnroe
2020-02-19Format WHOIS signon date with %F %TJune McEnroe
2020-02-19Apply word wrapping to tabs before setting alignJune McEnroe
2020-02-19Remove bad continues in styleParse loopsJune McEnroe
2020-02-19Various small cleanup in ui.cJune McEnroe
2020-02-17Use the correct hostname in error messagemultiplexd
2020-02-17Increase buffer size to 1024June McEnroe
2020-02-17Accept Shift-M-0 through Shift-M-9 as wellJune McEnroe
2020-02-17Only scroll after reflow if necessaryJune McEnroe
2020-02-17Scroll the window only once during reflowJune McEnroe
2020-02-16Various small cleanupsJune McEnroe
d something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu