summary refs log tree commit diff
path: root/config.c (unfollow)
Commit message (Expand)Author
2020-09-01Implement buffer line wrappingJune McEnroe
2020-09-01Invert meaning of unreadHard/unreadSoft to match new buffer codeJune McEnroe
2020-09-01Factor buffer out of uiJune McEnroe
2020-09-01Move styleParse out of uiJune McEnroe
2020-08-21Use a static buffer for base directory pathsJune McEnroe
2020-08-20Document how cert/priv are searched forJune McEnroe
2020-08-20Use configPath to load TLS cert/privJune McEnroe
2020-08-20Refactor base dir functions to iterate over pathsJune McEnroe
2020-08-18Match mentions case-sensitivelyJune McEnroe
2020-08-18Preserve colon from previous tab-completeJune McEnroe
2020-08-16Set origin fields to "*" if missingJune McEnroe
2020-08-06Set OPENSSL_BIN to /usr/bin/openssl on FreeBSD 1.1p1June McEnroe
2020-08-05Say for instead of withJune McEnroe
2020-08-04Mention LibreTLS in install instructionsJune McEnroe
2020-08-04Say "OpenSSL" in additional permission noticesJune McEnroe
2020-08-03Fix --mandir rendering in READMEJune McEnroe
2020-08-02Add \banhammer macroJune McEnroe
2020-08-01Check return value of asprintfJune McEnroe
2020-07-31Use ldd to automatically copy libs into chrootJune McEnroe
2020-07-31Fix path of cert.pem in chrootJune McEnroe
2020-07-31Fix chroot-man pathJune McEnroe
2020-07-30Replace catf with something that tracks lenJune McEnroe
2020-07-30Remove dependency on libcrypto for compatJune McEnroe
2020-07-30Define explicit_bzero using memset_s on macOSJune McEnroe
2020-07-30Remove use of strlcatJune McEnroe
2020-07-25Bump .so versions in chrootJune McEnroe
2020-07-23Support --prefix and --mandir in configure script 1.1June McEnroe
2020-07-23Rewrite configure script for all platformsJune McEnroe
2020-07-23Remove tls_close error handlingJune McEnroe
2020-07-23Initialize numHot, numWarmJune McEnroe
2020-07-13Add current topic to tab-complete so it can editedJune McEnroe
2020-07-12Keep scrolled up windows in status lineJune McEnroe
2020-07-09Don't scan ignored messages for URLsJune McEnroe
2020-07-08Add link to "IRC Suite" post in READMEJune McEnroe
2020-07-06Avoid copying message to match if no ignores are setJune McEnroe
2020-07-06Add message to ignore patternsJune McEnroe
2020-06-25Use DisableForwarding in sshd_configJune McEnroe
2020-06-24Bump ParamCap to 254June McEnroe
2020-06-16Color mentions up to first ": " rather than just ":"June McEnroe
2020-06-15Add null terminator to modes in channelListModeJune McEnroe
2020-06-12Document /quote needing /debug for outputJune McEnroe
2020-06-11Add OpenBSD to READMEJune McEnroe
2020-06-11Add warning to configure scriptJune McEnroe
2020-06-11Call static_assert by _Static_assertJune McEnroe
2020-06-08Add additional permission for linking with LibreSSLJune McEnroe
2020-05-27Inherit PREFIX and MANDIR from env 1.0June McEnroe
2020-05-26Don't send zero-width characters to ncursesJune McEnroe
2020-05-25Define constants for window geometryJune McEnroe
2020-05-24Tweak status line formattingJune McEnroe
2020-05-23Don't compress man page or use configure on FreeBSDJune McEnroe
solely built-in commands and functions, then zombies can hang around indefinitely. This patch fixes this by reaping when necessary after each built-in command and function. Reported-by: Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19redir: Fix typo in noclobber codeHerbert Xu The noclobber code has a typo in it that causes it to fail. This patch fixes it. Reported-by: Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19expand: Fix glibc glob(3) supportHerbert Xu It's been a while since we disabled glob(3) support by default. It appears to be working now, however, we have to change our code to detect the no-match case correctly. In particular, we need to test for GLOB_NOMAGIC | GLOB_NOCHECK instead of GLOB_MAGCHAR. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix buffer overflow in expandmetaHerbert Xu The native version of expandmeta allocates a buffer that may be overrun for two reasons. First of all the size is 1 byte too small but this is normally hidden because the minimum size is rounded up to 2048 bytes. Secondly, if the directory level is deep enough, any buffer can be overrun. This patch fixes both problems by calling realloc when necessary. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Move echo space/nl handling into print_escape_strHerbert Xu Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu