summary refs log tree commit diff
path: root/handle.c (follow)
Commit message (Expand)AuthorAge
* Replace catf with something that tracks lenJune McEnroe2020-07-30
* Remove use of strlcatJune McEnroe2020-07-30
* Add current topic to tab-complete so it can editedJune McEnroe2020-07-13
* Don't scan ignored messages for URLsJune McEnroe2020-07-09
* Bump ParamCap to 254June McEnroe2020-06-24
* Color mentions up to first ": " rather than just ":"June McEnroe2020-06-16
* Add additional permission for linking with LibreSSLJune McEnroe2020-06-08
* Check ignores against idJune McEnroe2020-04-07
* Error on missing MODE parametersJune McEnroe2020-04-05
* Error on invalid ISUPPORT valuesJune McEnroe2020-04-05
* Use gnu-case-range and gnu-conditional-omitted-operand extensionsJune McEnroe2020-04-03
* Add /ignore message filtering patternsJune McEnroe2020-03-31
* Replace some declaration; while loops with for loopsJune McEnroe2020-03-30
* Rewrite mode formatting again and write to logJune McEnroe2020-03-28
* Log chat eventsJune McEnroe2020-03-25
* Track MODE in repliesJune McEnroe2020-03-23
* Assume worst case for unknown user and host in splitMessageJune McEnroe2020-03-23
* Track own host, handle CHGHOSTJune McEnroe2020-03-22
* Handle RPL_CHANNELMODEISJune McEnroe2020-03-22
* Handle user mode changesJune McEnroe2020-03-22
* Rewrite handleModeJune McEnroe2020-03-22
* Handle RPL_UMODEISJune McEnroe2020-03-18
* Ignore 422 ERR_NOMOTDJune McEnroe2020-03-09
* Set self.pos before handling the messageJune McEnroe2020-03-08
* Implement the causal.agency/consumer capabilityJune McEnroe2020-02-29
* Add raw modes to mode messageJune McEnroe2020-02-25
* Handle changing setParamModes, paramModes and other channel modesJune McEnroe2020-02-25
* Fix handling EXCEPTS and INVEX without valuesJune McEnroe2020-02-25
* Add /mode, /except, /invex and handle lists repliesJune McEnroe2020-02-25
* Accumulate mode changes into a buffer for one messageJune McEnroe2020-02-23
* Handle ERR_CHANOPRIVSNEEDEDJune McEnroe2020-02-20
* Handle MODE changing channel list modesJune McEnroe2020-02-20
* Handle MODE setting channel prefix modesJune McEnroe2020-02-20
* Change ban list formattingJune McEnroe2020-02-20
* Rearrange some handlersJune McEnroe2020-02-20
* Handle RPL_INVITING when no invite-notifyJune McEnroe2020-02-20
* Handle ERR_BANLISTFULLJune McEnroe2020-02-20
* Add handlers for user-in-channel errorsJune McEnroe2020-02-20
* Add generic error reply handlerJune McEnroe2020-02-20
* Add /ban, /unban and handle ban list repliesJune McEnroe2020-02-19
* Format WHOIS signon date with %F %TJune McEnroe2020-02-19
* Replace a lot of snprintf with a catf implementationJune McEnroe2020-02-16
* Add 379 to WHOIS responsesJune McEnroe2020-02-16
* Track EXCEPTS and INVEX modesJune McEnroe2020-02-16
* Apply colorMentions to actionsJune McEnroe2020-02-16
* Replace small integers in size_t with uintJune McEnroe2020-02-15
* Still add nick without prefixes to completeJune McEnroe2020-02-15
* Track PREFIX modes and CHANMODESJune McEnroe2020-02-15
* Show prefixes in NAMES and WHOIS repliesJune McEnroe2020-02-15
* Separate network info from selfJune McEnroe2020-02-15
low=1'>expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu