summary refs log tree commit diff
path: root/scripts/.gitignore (unfollow)
Commit message (Expand)Author
2020-02-20Add handlers for user-in-channel errorsJune McEnroe
2020-02-20Add generic error reply handlerJune McEnroe
2020-02-19Add /ban, /unban and handle ban list repliesJune McEnroe
2020-02-19Format WHOIS signon date with %F %TJune McEnroe
2020-02-19Apply word wrapping to tabs before setting alignJune McEnroe
2020-02-19Remove bad continues in styleParse loopsJune McEnroe
2020-02-19Various small cleanup in ui.cJune McEnroe
2020-02-17Use the correct hostname in error messagemultiplexd
2020-02-17Increase buffer size to 1024June McEnroe
2020-02-17Accept Shift-M-0 through Shift-M-9 as wellJune McEnroe
2020-02-17Only scroll after reflow if necessaryJune McEnroe
2020-02-17Scroll the window only once during reflowJune McEnroe
2020-02-16Various small cleanupsJune McEnroe
2020-02-16Replace a lot of snprintf with a catf implementationJune McEnroe
2020-02-16Add 379 to WHOIS responsesJune McEnroe
2020-02-16Track EXCEPTS and INVEX modesJune McEnroe
2020-02-16Add RFC 1459 and modern.ircdocs.horse referencesJune McEnroe
2020-02-16Re-sort STANDARDS sectionJune McEnroe
2020-02-16Apply colorMentions to actionsJune McEnroe
2020-02-15Set defaults for various types of modesJune McEnroe
2020-02-15Replace small integers in size_t with uintJune McEnroe
2020-02-15Still add nick without prefixes to completeJune McEnroe
2020-02-15Track PREFIX modes and CHANMODESJune McEnroe
2020-02-15Show prefixes in NAMES and WHOIS repliesJune McEnroe
2020-02-15Enable multi-prefixJune McEnroe
2020-02-15Separate network info from selfJune McEnroe
2020-02-15Add /ns and /csJune McEnroe
2020-02-15Document exit statusJune McEnroe
2020-02-14Add /kickJune McEnroe
2020-02-14Add /inviteJune McEnroe
2020-02-14Add /awayJune McEnroe
2020-02-14Save heat, unreadTotal, unreadWarmJune McEnroe
2020-02-14Track unreadTotal and unreadWarm separatelyJune McEnroe
2020-02-14Don't copy into cut buffer during tab completeJune McEnroe
2020-02-13Set hidden to true initiallyJune McEnroe
2020-02-13Document environment variables usedJune McEnroe
2020-02-13Add /execJune McEnroe
2020-02-13Only uiShow if hidden and only uiHide if shownJune McEnroe
2020-02-13Rename procPipe to utilPipeJune McEnroe
2020-02-13Set swap correctly when closing a windowJune McEnroe
2020-02-13Refactor windows into array and add /moveJune McEnroe
2020-02-13Clean up manual lintsJune McEnroe
2020-02-13Add -g for generating certificatesJune McEnroe
2020-02-13Explicitly close the TLS connectionJune McEnroe
2020-02-12Add sandman wrapperJune McEnroe
2020-02-12Document scripts in READMEJune McEnroe
2020-02-12Add -N flag for notificationsJune McEnroe
2020-02-12Mark and unmark on uiHide, uiShowJune McEnroe
2020-02-12Hide debug prompt if buffer starts with /June McEnroe
2020-02-12Only exit on errorneous nick during registrationJune McEnroe
mat parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu