about summary refs log tree commit diff
diff options
context:
space:
mode:
authorLukas Fleischer <cgit@cryptocrack.de>2013-03-04 13:25:38 +0100
committerJason A. Donenfeld <Jason@zx2c4.com>2013-03-04 20:47:54 -0500
commit59fe348deaa270434f05afc56ca8d13618af9ca9 (patch)
treef9122014182ced8f9b7071c4ef69adfc2d7042fd
parentcgit_print_commit(): Free tmp variable (diff)
downloadcgit-pink-59fe348deaa270434f05afc56ca8d13618af9ca9.tar.gz
cgit-pink-59fe348deaa270434f05afc56ca8d13618af9ca9.zip
cgit_print_snapshot_links(): Free prefix variable
Fixes following memory leak seen with "PATH_INFO=/cgit/commit/":

    ==16894== 12 bytes in 1 blocks are definitely lost in loss record 9 of 92
    ==16894==    at 0x4C2C04B: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==16894==    by 0x56F2DF1: strdup (in /usr/lib/libc-2.17.so)
    ==16894==    by 0x46CAC8: xstrdup (wrapper.c:35)
    ==16894==    by 0x414E34: cgit_print_snapshot_links (ui-shared.c:926)
    ==16894==    by 0x40CFA1: cgit_print_commit (ui-commit.c:102)
    ==16894==    by 0x407B06: commit_fn (cmd.c:54)
    ==16894==    by 0x405E16: process_request (cgit.c:574)
    ==16894==    by 0x4074C8: cache_process (cache.c:322)
    ==16894==    by 0x406C4F: main (cgit.c:872)

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
-rw-r--r--ui-shared.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/ui-shared.c b/ui-shared.c
index 77a302d..d3e6488 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -931,4 +931,5 @@ void cgit_print_snapshot_links(const char *repo, const char *head,
 		cgit_snapshot_link(filename, NULL, NULL, NULL, NULL, filename);
 		html("<br/>");
 	}
+	free(prefix);
 }