about summary refs log tree commit diff
diff options
context:
space:
mode:
authorChristian Hesse <mail@eworm.de>2015-10-09 13:15:51 +0200
committerJason A. Donenfeld <Jason@zx2c4.com>2015-10-09 14:04:42 +0200
commit6edfc1672cdc5eb0dfb0ff5db0ec1de1ec53415e (patch)
tree9fbff90b162ac0e9418034449cc350ed4f6d66ae
parentui-shared: return value of cgit_hosturl is not const (diff)
downloadcgit-pink-6edfc1672cdc5eb0dfb0ff5db0ec1de1ec53415e.tar.gz
cgit-pink-6edfc1672cdc5eb0dfb0ff5db0ec1de1ec53415e.zip
ui-shared: fix resource leak: free allocation from cgit_hosturl
Signed-off-by: Christian Hesse <mail@eworm.de>
-rw-r--r--ui-shared.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/ui-shared.c b/ui-shared.c
index 09c34fd..c04f380 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -730,7 +730,7 @@ void cgit_print_docstart(void)
 		return;
 	}
 
-	const char *host = cgit_hosturl();
+	char *host = cgit_hosturl();
 	html(cgit_doctype);
 	html("<html xmlns='http://www.w3.org/1999/xhtml' xml:lang='en' lang='en'>\n");
 	html("<head>\n");
@@ -755,7 +755,7 @@ void cgit_print_docstart(void)
 
 		html("<link rel='alternate' title='Atom feed' href='");
 		html(cgit_httpscheme());
-		html_attr(cgit_hosturl());
+		html_attr(host);
 		fileurl = cgit_fileurl(ctx.repo->url, "atom", ctx.qry.vpath,
 				       sb.buf);
 		html_attr(fileurl);
@@ -771,6 +771,7 @@ void cgit_print_docstart(void)
 	html("<body>\n");
 	if (ctx.cfg.header)
 		html_include(ctx.cfg.header);
+	free(host);
 }
 
 void cgit_print_docend(void)