about summary refs log tree commit diff
diff options
context:
space:
mode:
authorLars Hjemli <hjemli@gmail.com>2007-12-18 08:26:50 +0000
committerLars Hjemli <hjemli@gmail.com>2008-01-10 12:50:12 +0100
commitf39c3c99a12154cdafcdc501a821e3fadd3c0602 (patch)
treeafd672cf704388099510977fe4882dabb66f7463
parentHandle missing default branch and error out on invalid branch names (diff)
downloadcgit-pink-f39c3c99a12154cdafcdc501a821e3fadd3c0602.tar.gz
cgit-pink-f39c3c99a12154cdafcdc501a821e3fadd3c0602.zip
Check for NULL-subject in patch view
While at it, make sure the commit message ends with a '\n'.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r--ui-patch.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/ui-patch.c b/ui-patch.c
index ef79c7c..e7a010a 100644
--- a/ui-patch.c
+++ b/ui-patch.c
@@ -96,7 +96,12 @@ void cgit_print_patch(char *hex, struct cacheitem *item)
 	htmlf("From: %s%s\n", info->author, info->author_email);
 	html("Date: ");
 	cgit_print_date(info->author_date, "%a, %d  %b  %Y  %H:%M:%S  %z%n");
-	htmlf("Subject: %s\n\n%s", info->subject, info->msg);
+	htmlf("Subject: %s\n\n", info->subject);
+	if (info->msg && *info->msg) {
+		htmlf("%s", info->msg);
+		if (info->msg[strlen(info->msg) - 1] != '\n')
+			html("\n");
+	}
 	html("---\n");
 	cgit_diff_tree(old_sha1, sha1, filepair_cb, NULL);
 	html("--\n");
4.0&id=927060c5d8d82a9422fc1dcf6d1379d21071b158&follow=1'>ui-log: add <span/> around commit decorationsJohn Keeping 2013-05-22Makefile: fix parallel "make test"John Keeping 2013-05-18cache.c: fix cache_lsJohn Keeping 2013-05-13t0109: "function" is a bash-ismJohn Keeping 2013-05-13New mailing list.Jason A. Donenfeld 2013-04-30ui-snapshot: do not access $HOMEJason A. Donenfeld 2013-04-27t0001: validate Git -rcN version numbers correctlyJohn Keeping 2013-04-27git: update to 1.8.2.2John Keeping 2013-04-17scan-tree: fix regression in section-from-path=-1John Keeping 2013-04-15t0001: ignore ".dirty" suffix on Git versionJohn Keeping 2013-04-15tests: set TEST_OUTPUT_DIRECTORY to the CGit test directoryJohn Keeping 2013-04-15t0109: test more URLsJohn Keeping 2013-04-10cgitrc.5.txt: Specify when scan-path must be defined before.Jason A. Donenfeld 2013-04-10ui-snapshot.c: Prepend "V" when guessing ref namesLukas Fleischer 2013-04-10t0107: Skip ZIP tests if unzip(1) isn't availableLukas Fleischer 2013-04-10tests/: Do not use `sed -i`Lukas Fleischer 2013-04-10Add branch-sort and repo.branch-sort options.Jason A. Donenfeld 2013-04-10t0109: chain operations with &&John Keeping 2013-04-10cgit.c: Do not restore unset environment variablesLukas Fleischer 2013-04-09t0107: Use `tar -z` for gzip'ed archivesLukas Fleischer