diff options
author | John Keeping <john@keeping.me.uk> | 2013-04-01 19:03:34 +0100 |
---|---|---|
committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2013-04-08 15:59:46 +0200 |
commit | b1f17f168b91d709c0c0e62608de301a36f06da9 (patch) | |
tree | 9aff1fe903087cb5016ab2afdb32a7ca1cc139b2 /cgit.css | |
parent | ui-refs.c: Refactor print_tag() (diff) | |
download | cgit-pink-b1f17f168b91d709c0c0e62608de301a36f06da9.tar.gz cgit-pink-b1f17f168b91d709c0c0e62608de301a36f06da9.zip |
Fix out-of-bounds memory accesses with virtual_root=""
The CGit configuration variable virtual_root is normalized so that it does not have a trailing '/' character, but it is allowed to be empty (the empty string and NULL have different meanings here) and there is code that is insufficiently cautious when checking if it ends in a '/': if (virtual_root[strlen(virtual_root) - 1] != '/') Clearly this check is redundant, but rather than simply removing it we get a slight efficiency improvement by switching the normalization so that the virtual_root variable always ends in '/'. Do this with a new "ensure_end" helper. Signed-off-by: John Keeping <john@keeping.me.uk>
Diffstat (limited to 'cgit.css')
0 files changed, 0 insertions, 0 deletions