about summary refs log tree commit diff
path: root/ui-commit.c
diff options
context:
space:
mode:
Diffstat (limited to 'ui-commit.c')
-rw-r--r--ui-commit.c17
1 files changed, 9 insertions, 8 deletions
diff --git a/ui-commit.c b/ui-commit.c
index f654208..8916212 100644
--- a/ui-commit.c
+++ b/ui-commit.c
@@ -13,20 +13,18 @@ void cgit_print_commit(const char *hex)
 	struct commit *commit;
 	struct commitinfo *info;
 	struct commit_list *p;
-
 	unsigned char sha1[20];
+	char *query;
 
 	if (get_sha1(hex, sha1)) {
 		cgit_print_error(fmt("Bad object id: %s", hex));
 		return;
 	}
-
 	commit = lookup_commit_reference(sha1);
 	if (!commit) {
 		cgit_print_error(fmt("Bad commit reference: %s", hex));
 		return;
 	}
-
 	info = cgit_parse_commit(commit);
 
 	html("<table class='commit-info'>\n");
@@ -45,12 +43,15 @@ void cgit_print_commit(const char *hex)
 	cgit_print_date(info->committer_date);
 	html("</td></tr>\n");
 	html("<tr><th>tree</th><td colspan='2' class='sha1'><a href='");
-	html_attr(cgit_pageurl(cgit_query_repo, "tree", fmt("id=%s", sha1_to_hex(commit->tree->object.sha1))));
+	query = fmt("id=%s", sha1_to_hex(commit->tree->object.sha1));
+	html_attr(cgit_pageurl(cgit_query_repo, "tree", query));
 	htmlf("'>%s</a></td></tr>\n", sha1_to_hex(commit->tree->object.sha1));
-	
-	for (p = commit->parents; p ; p = p->next) {
-		html("<tr><th>parent</th><td colspan='2' class='sha1'><a href='");
-		html_attr(cgit_pageurl(cgit_query_repo, "commit", fmt("id=%s", sha1_to_hex(p->item->object.sha1))));
+      	for (p = commit->parents; p ; p = p->next) {
+		html("<tr><th>parent</th>"
+		     "<td colspan='2' class='sha1'>"
+		     "<a href='");
+		query = fmt("id=%s", sha1_to_hex(p->item->object.sha1));
+		html_attr(cgit_pageurl(cgit_query_repo, "commit", query));
 		htmlf("'>%s</a></td></tr>\n", 
 		      sha1_to_hex(p->item->object.sha1));
 	}