about summary refs log tree commit diff
path: root/ui-tree.c (follow)
Commit message (Expand)AuthorAge
* prefer html_raw() to write()Mark Lodato2010-09-04
* fix errors in printf-style format stringsMark Lodato2010-09-04
* ui-tree: Remove unnecessary path breadcrumb navigationJohan Herland2010-06-19
* ui-tree: add link to plain view for blobs in tree listingLars Hjemli2010-02-28
* Merge branch 'stable'Lars Hjemli2009-12-12
|\
| * Fix segfault on ppc when browsing treeMartins Polakovs2009-12-12
* | "max-blob-size" config var to limit generated HTML sizeGeorg Lukas2009-11-28
|/
* Rename "linenumbers" to "enable-tree-linenumbers", change default to "1"Lars Hjemli2009-08-21
* Add 'linenumbers' config optionFlorian Pritz2009-08-21
* ui-tree.c: show line numbers when highlightingFlorian Pritz2009-08-21
* Merge branch 'lh/plugins'Lars Hjemli2009-08-09
|\
| * Add support for repo.commit-filter and repo.source-filterLars Hjemli2009-08-09
| * ui-tree: add support for source-filter optionLars Hjemli2009-07-31
* | Expose file extension in tree lists as class to allow nicer tree stylingMartin Szulecki2009-08-08
|/
* fix segfault when displaying empty blobsEric Wong2009-03-15
* ui-tree: escape ascii-text properly in hexdump viewLars Hjemli2009-02-12
* ui-tree: show hexdump of binary blobsLars Hjemli2009-01-31
* Merge branch 'og/tree-view-selection'Lars Hjemli2009-01-27
|\
| * changed objects are outputted, allowing for selections of code onlyOnne Gorter2009-01-10
* | Merge branch 'lh/stats'Lars Hjemli2009-01-27
|\ \ | |/ |/|
| * ui-tree: add link to stats page per pathLars Hjemli2008-12-07
* | Merge branch 'stable'Lars Hjemli2009-01-06
|\ \
| * | ui-tree.c: do not add blank line when displaying blobsLars Hjemli2009-01-06
| |/
* / ui-log: add support for showing the full commit messageLars Hjemli2008-11-29
|/
* ui-tree: link to plain view instead of blob viewLars Hjemli2008-08-06
* Adjust to new calling convention for read_tree_recursive()Lars Hjemli2008-07-21
* ui-tree.c: avoid peeking at GITLINK objectsLars Hjemli2008-05-20
* Don't specify mimetype in ui-blob.cLars Hjemli2008-04-08
* Add ui-shared.hLars Hjemli2008-03-24
* Introduce html.hLars Hjemli2008-03-18
* Move cgit_repo into cgit_contextLars Hjemli2008-02-16
* Introduce struct cgit_contextLars Hjemli2008-02-16
* Fix html error detected by test-suiteLars Hjemli2007-11-11
* Add search parameters to cgit_log_linkLars Hjemli2007-11-03
* Remove a few compiler warningsLars Hjemli2007-09-20
* ui-tree: show last line of blobLars Hjemli2007-09-20
* ui-tree: specify parameter position for all htmlf formatsLars Hjemli2007-09-19
* Merge branch 'jo/dirlink'Lars Hjemli2007-09-03
|\
| * Rename dirlink to gitlink.Jeffrey C. Ollie2007-06-04
* | Add support for line number in url fragmentLars Hjemli2007-07-23
* | link raw blob from tree file viewMichael Krelin2007-07-21
* | Add ofs argument to cgit_log_link and use it in ui-log.cLars Hjemli2007-06-29
* | Change S/L/T to summary/log/treeLars Hjemli2007-06-18
* | Add cgit_commit_link() + support for id=sha1 to commit viewLars Hjemli2007-06-17
* | Add git_log_link() and fix bug in generic repolink functionLars Hjemli2007-06-17
* | ui-tree: html/css cleanupLars Hjemli2007-06-17
* | Add and use cgit_tree_link()Lars Hjemli2007-06-17
* | ui-tree: make blob viewer generate valid htmlLars Hjemli2007-06-16
* | ui-tree: unify with ui-view, use path to select tree/blobLars Hjemli2007-06-16
|/
* Use & instead of & in URLs.Ondrej Jirman2007-05-31
generated by cgit-pink 1.4.1 (git 2.36.1) at 2025-02-17 10:56:23 +0000
ld generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu