diff options
| author | Harald van Dijk <harald@gigawatt.nl> | 2014-09-26 22:27:13 +0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2014-09-26 22:27:13 +0800 |
| commit | 4c44561d9f97331bb23f900f47a69305091f3ab3 (patch) | |
| tree | f1cd0d1497ec8866b739fb6616c1753256993a36 | |
| parent | [BUILTIN] Set command -p path to /usr/sbin:/usr/bin:/sbin:/bin (diff) | |
| download | dash-4c44561d9f97331bb23f900f47a69305091f3ab3.tar.gz dash-4c44561d9f97331bb23f900f47a69305091f3ab3.zip | |
[JOBS] Fix off-by-one error for multiple of four job numbers
On 29/07/13 23:44, Luigi Tarenga wrote: > hi list, > while writing a script to execute parallel ssh command on many host I found > a strange behavior of dash. I can replicate it with a very simple script but > didn't find any documentation about dash or POSIX that can explain it. > > tested on centos 6.4 (dash 0.5.5.1) and wih dash compiled from source (0.5.7) > the following script reports error: > > #!/bin/dash > > sleep 3 & > sleep 3 & > sleep 3 & > sleep 3 & > > #/bin/true > jobs -l > > wait %1 > wait %2 > wait %3 > wait %4 > > [vortex@lizard ~]$ ./dash-0.5.7/src/dash test.sh > [4] + 4569 Running > [3] - 4568 Running > [2] 4567 Running > [1] 4566 Running > prova: 14: wait: No such job: %4 > [vortex@lizard ~]$ echo $? > 2 Yes, this looks like a bug to me. The number of allocated jobs is always kept as a multiple of four, and the first check in considering whether the job number is valid is "if it's greater than or equal to the number of allocated job, it's invalid". That doesn't look right. That would only be right if jobs were zero-based, but they aren't. If it's exactly equal to the number of available jobs, it can still be valid. It works when adding /bin/true, because four more more jobs end up allocated internally. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| -rw-r--r-- | ChangeLog | 1 | ||||
| -rw-r--r-- | src/jobs.c | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog index ba67b6e..7b67c0c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -6,6 +6,7 @@ 2014-09-26 Harald van Dijk <harald@gigawatt.nl> * command: allow combining -p with -v. + * getjob: Fix off-by-one error for multiple of four job numbers 2013-08-23 Herbert Xu <herbert@gondor.apana.org.au> diff --git a/src/jobs.c b/src/jobs.c index bf40204..c2c2332 100644 --- a/src/jobs.c +++ b/src/jobs.c @@ -699,7 +699,7 @@ check: if (is_number(p)) { num = atoi(p); - if (num < njobs) { + if (num <= njobs) { jp = jobtab + num - 1; if (jp->used) goto gotit; |