summary refs log tree commit diff
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2014-10-28 10:32:03 +0800
committerHerbert Xu <herbert@gondor.apana.org.au>2014-10-28 10:32:03 +0800
commita31c812b02d7fc331f8a0c5aedbbf12b4025c1db (patch)
tree11831b7435e94df92ad68b2bf69ae0957249607f
parent[BUILTIN] Handle -- in dotcmd (diff)
downloaddash-a31c812b02d7fc331f8a0c5aedbbf12b4025c1db.tar.gz
dash-a31c812b02d7fc331f8a0c5aedbbf12b4025c1db.zip
[PARSER] Removed unnecessary pungetc on EOF from parser
Doing a pungetc on an EOF is a noop and is only useful when we
don't know what character we're putting back.  This patch removes
an unnecessary pungetc when we know it's EOF.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--ChangeLog4
-rw-r--r--src/parser.c2
2 files changed, 4 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 5212a9a..70ccfed 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2014-10-28  Herbert Xu <herbert@gondor.apana.org.au>
+
+	* Removed unnecessary pungetc on EOF from parser.
+
 2014-10-27  Herbert Xu <herbert@gondor.apana.org.au>
 
 	* Add printf support for format string a, A, and F.
diff --git a/src/parser.c b/src/parser.c
index f6c43be..f0c919d 100644
--- a/src/parser.c
+++ b/src/parser.c
@@ -208,8 +208,6 @@ list(int nlflag)
 		case TEOF:
 			if (heredoclist)
 				parseheredoc();
-			else
-				pungetc();		/* push back EOF on input */
 			tokpushback++;
 			return n1;
 		default: