summary refs log tree commit diff
path: root/src/eval.c
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2010-05-27 11:50:19 +0800
committerHerbert Xu <herbert@gondor.apana.org.au>2010-05-27 11:50:19 +0800
commit1d806ac1fbafb867f6252e184e1be05c0829ab71 (patch)
treeb53f7fc72f3d535437421c57653196a8b0d40663 /src/eval.c
parent[VAR] Document local command behaviour change (diff)
downloaddash-1d806ac1fbafb867f6252e184e1be05c0829ab71.tar.gz
dash-1d806ac1fbafb867f6252e184e1be05c0829ab71.zip
[VAR] Do not poplocalvars prematurely on regular utilities
The recent cmdenviron removal broke regular utilities by calling
poplocalvars too early.  This patch fixes that by postponing the
poplocalvars for regular utilities until they have completed.

In order to ensure that local still works, it is now a special
built-in.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'src/eval.c')
-rw-r--r--src/eval.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/eval.c b/src/eval.c
index 2cd931b..337667f 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -847,9 +847,11 @@ bail:
 		/* NOTREACHED */
 
 	case CMDBUILTIN:
-		poplocalvars(spclbltin > 0 || argc == 0);
-		if (execcmd && argc > 1)
-			listsetvar(varlist.list, VEXPORT);
+		if (spclbltin > 0 || argc == 0) {
+			poplocalvars(1);
+			if (execcmd && argc > 1)
+				listsetvar(varlist.list, VEXPORT);
+		}
 		if (evalbltin(cmdentry.u.cmd, argc, argv, flags)) {
 			int status;
 			int i;