summary refs log tree commit diff
path: root/src/show.c
diff options
context:
space:
mode:
authorMartijn Dekker <martijn@inlv.org>2018-03-07 13:03:26 +0000
committerHerbert Xu <herbert@gondor.apana.org.au>2018-03-10 16:01:43 +0800
commit2b3fb53c6940471955631353b8bdb7d5a4677fd1 (patch)
treec5471c418e9445ea84fd2b4ad35c01c5cdfc12ff /src/show.c
parentexpand: 'nolog' and 'debug' options cause "$-" to wreak havoc (diff)
downloaddash-2b3fb53c6940471955631353b8bdb7d5a4677fd1.tar.gz
dash-2b3fb53c6940471955631353b8bdb7d5a4677fd1.zip
mystring: fix "Illegal number" on FreeBSD & macOS for x=; echo $((x))
Op 07-03-18 om 06:26 schreef Herbert Xu:
> Martijn Dekker <martijn@inlv.org> wrote:
>>
>>> Since base is always a constant 0 or a constant 10, never a
>>> user-provided value, the only error that strtoimax will ever report on
>>> glibc systems is ERANGE. Checking only ERANGE therefore preserves the
>>> glibc behaviour, and allows the exact same set of errors to be detected
>>> on non-glibc systems.
>>
>> That makes sense, thanks.
>
> Could you resend your patch with this change please?

OK, see below.

- M.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'src/show.c')
0 files changed, 0 insertions, 0 deletions
ink/commit/cgit.mk?h=1.3.0&id=a5e4ad2d8b9c6bcfc7029894d3a3837166996b35&follow=1'>cgit.mk: fix dependency handlingJohn Keeping 2013-04-08Makefile: re-include cgit.conf in cgit.mkJohn Keeping 2013-04-08Do not unnecessarily strdup() environment variablesLukas Fleischer 2013-04-08Maŕk cgit_environment members constLukas Fleischer 2013-04-08Return const char * in cgit_{httpscheme, hosturl, rooturl}()Lukas Fleischer 2013-04-08Update git to v1.8.2.1John Keeping 2013-04-07ui-blob: don't segfault when no path is givenJohn Keeping 2013-03-20Convert pager navigation into a unordered listLukas Fleischer 2013-03-20Makefile: remove CGIT-CFLAGS files in clean stageJason A. Donenfeld 2013-03-20ui-summary.c: Move urls variable into print_urls()Lukas Fleischer 2013-03-20Fix colspan valuesLukas Fleischer 2013-03-20html: check return value of writeJason A. Donenfeld 2013-03-20ui-shared: squelch compiler warning.Jason A. Donenfeld 2013-03-20cgit.mk: Use SHELL_PATH_SQ to run gen-version.shJohn Keeping 2013-03-20cgit.mk: don't rebuild everything if CGIT_VERSION changesJohn Keeping 2013-03-20ui-patch: use cgit_version not CGIT_VERSIONJohn Keeping 2013-03-20Makefile: re-use Git's Makefile where possibleJohn Keeping