summary refs log tree commit diff
path: root/src (follow)
Commit message (Expand)AuthorAge
* parser: Fix single-quoted patterns in here-documentsHerbert Xu2018-03-22
* parser: Add syntax stack for recursive parsingHerbert Xu2018-03-22
* parser: use pgetc_eatbnl() in more placesHarald van Dijk2018-03-22
* builtin: Greater resolution in test -nt / test -otMartijn Dekker2018-03-22
* mystring: fix "Illegal number" on FreeBSD & macOS for x=; echo $((x))Martijn Dekker2018-03-10
* expand: 'nolog' and 'debug' options cause "$-" to wreak havocMartijn Dekker2018-03-10
* histedit: fix build with musl libcBaruch Siach2018-03-10
* expand: Remove dependency on fmatch.h if it does not exitRink Springer2018-03-10
* input: Fix here-document redirection with vi/emacs onHarald van Dijk2018-03-10
* man: Small cleanup for Command Line EditingLarry Hynes2018-03-10
* builtin: describe_command - fix incorrect pathHarald van Dijk2018-03-10
* trap: Globally rename pendingsigs to pending_sigDenys Vlasenko2018-03-10
* expand - Fix dangling left square brackets in patternsHerbert Xu2016-09-23
* builtin: Fix echo -n early terminationHerbert Xu2016-09-02
* builtin: Fix handling of trailing IFS white spacesHerbert Xu2016-09-02
* eval: Return status in eval functionsHerbert Xu2016-09-02
* jobs: Handle string-based job descriptorsStephen Kitt2016-09-02
* trap: Implement POSIX.1-2008 trap reset behaviourHerbert Xu2016-09-02
* eval: Fix exit status when calling eval/dot with no commandsHarald van Dijk2016-06-07
* man: Document ulimit -vGioele Barabucci2016-06-06
* shell: Fix build on Solaris 9Jonathan Perkin2016-06-06
* jobs: Don't attempt to access job table for job %0Tobias Klauser2016-06-06
* builtin: Reject malformed printf specifications with digits after '*'Patrick Brown2016-06-06
* builtin: Reset t_wp_op in testcmdHerbert Xu2015-08-13
* man: Fix description of getopts when last argument reachedFelix Dietrich2015-06-11
* builtin: Clear LC_ALL in mkbuiltinsFredrik Fornwall2015-06-11
* input: Allow two consecutive calls to pungetcHerbert Xu2015-01-05
* input: Move all input state into parsefileHerbert Xu2015-01-05
* input: Remove HETIOHerbert Xu2015-01-05
* input: Make preadbuffer staticHerbert Xu2015-01-05
* expand: Fixed "$@" expansion when EXP_FULL is falseHerbert Xu2015-01-05
* builtin: create builtins.c properly on old cppkabe@sra-tohoku.co.jp2014-12-26
* man: Clarify two redirection mechanismsStéphane Aulery2014-12-26
* [BUILTIN] Fix "test -x" as root on FreeBSD 8Jonathan Nieder2014-11-17
* [MAN] Document redirection file descriptor limitationStéphane Aulery2014-11-17
* [MAN] Correct typo in manual pageStéphane Aulery2014-11-17
* [PARSER] Catch variable length expansions on non-existant specialsHerbert Xu2014-10-30
* [PARSER] Simplify EOF/newline handling in list parserHerbert Xu2014-10-28
* [PARSER] Removed unnecessary pungetc on EOF from parserHerbert Xu2014-10-28
* [BUILTIN] Handle -- in dotcmdHerbert Xu2014-10-27
* [BUILTIN] Simplify echo commandHerbert Xu2014-10-27
* [BUILTIN] Optimise handling of backslash octals in printfHerbert Xu2014-10-27
* [BUILTIN] Use error instead of warnx for fatal errors in printfHerbert Xu2014-10-27
* [BUILTIN] Remove getintmax in printfHerbert Xu2014-10-27
* [BUILTIN] Remove unnecessary restoration of format string in printfHerbert Xu2014-10-27
* [OUTPUT] Add ifdefs around MEM_OUT handling in outmemHerbert Xu2014-10-27
* [OUTPUT] Add likely tag in outmemHerbert Xu2014-10-27
* [INPUT] Replace open-coded flushall in preadbufferHerbert Xu2014-10-27
* [BUILTIN] Handle embedded NULs correctly in printfHerbert Xu2014-10-27
* [BUILTIN] Add printf support for format string a, A, and FHerbert Xu2014-10-27
generated by cgit-pink 1.4.1 (git 2.36.1) at 2026-10-27 04:48:24 +0000
b0b3&follow=1'>redir: Fix typo in noclobber codeHerbert Xu The noclobber code has a typo in it that causes it to fail. This patch fixes it. Reported-by: Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19expand: Fix glibc glob(3) supportHerbert Xu It's been a while since we disabled glob(3) support by default. It appears to be working now, however, we have to change our code to detect the no-match case correctly. In particular, we need to test for GLOB_NOMAGIC | GLOB_NOCHECK instead of GLOB_MAGCHAR. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix buffer overflow in expandmetaHerbert Xu The native version of expandmeta allocates a buffer that may be overrun for two reasons. First of all the size is 1 byte too small but this is normally hidden because the minimum size is rounded up to 2048 bytes. Secondly, if the directory level is deep enough, any buffer can be overrun. This patch fixes both problems by calling realloc when necessary. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Move echo space/nl handling into print_escape_strHerbert Xu Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu