about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2019-12-21 06:35:51 -0500
committerJune McEnroe <june@causal.agency>2019-12-21 06:35:51 -0500
commit9059861edf2ba68c5ea356918a0347323c9f0d2b (patch)
treee945a6127911d1739991c17f9a7ff0148cc64eca
parentAdd copy of GPL (diff)
downloadimbox-9059861edf2ba68c5ea356918a0347323c9f0d2b.tar.gz
imbox-9059861edf2ba68c5ea356918a0347323c9f0d2b.zip
Null-terminate read literals
No wonder there was garbage... Silly mistake!
Diffstat (limited to '')
-rw-r--r--imbox.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/imbox.c b/imbox.c
index 9f46983..1712615 100644
--- a/imbox.c
+++ b/imbox.c
@@ -65,8 +65,6 @@ static void mboxrd(const char *headers, const char *body) {
 	);
 
 	printf("%s", headers);
-	// FIXME: There seems to sometimes be some garbage data at the end of the
-	// headers?
 
 	static regex_t quoteRegex;
 	compile(&quoteRegex, "^>*From ");
@@ -161,12 +159,13 @@ static char *readLiteral(FILE *imap, const char *line) {
 	size_t size = strtoul(prefix + 1, NULL, 10);
 	if (!size) errx(EX_PROTOCOL, "invalid literal size");
 
-	char *literal = malloc(size);
+	char *literal = malloc(size + 1);
 	if (!literal) err(EX_OSERR, "malloc");
 
 	size_t count = fread(literal, size, 1, imap);
 	if (!count) errx(EX_PROTOCOL, "could not read literal");
 
+	literal[size] = '\0';
 	return literal;
 }
 
td>June McEnroe vaswprintf is a nightmare. 2018-08-06Rename line editing functionsJune McEnroe 2018-08-05Initialize all possible color pairsJune McEnroe This is actually possible with use_default_colors! 2018-08-05Refactor color initializationJune McEnroe 2018-08-05Add ^L redrawJune McEnroe 2018-08-05Use 16 colors if availableJune McEnroe Fall back to using bold if there are only 8 colors. This also allowed bright background colors in 16-color terminals. I must port this system to torus. I'll be able to remove the awful termcap patch hack. 2018-08-05Limit parsed colors to number of mIRC colorsJune McEnroe Oh boy that's embarrassing. 2018-08-04Show source link on exitJune McEnroe 2018-08-04Implement line editing, scrollingJune McEnroe Don't really have a way to implement the M-* keys, and currently missing C-w. 2018-08-04Handle /topicJune McEnroe