summary refs log tree commit diff
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2021-09-02 21:34:43 -0400
committerJune McEnroe <june@causal.agency>2021-09-02 21:34:43 -0400
commit9569b2eb98c6dd8015e3a4802184f90d211ea75f (patch)
treeb2d6f1a65355ff856691bf5e272269a6bc21e7e4
parentOpenBSD: pledge(2) the genCert code path (diff)
downloadpounce-9569b2eb98c6dd8015e3a4802184f90d211ea75f.tar.gz
pounce-9569b2eb98c6dd8015e3a4802184f90d211ea75f.zip
Remove redundant clientDiff function
Diffstat (limited to '')
-rw-r--r--bounce.c5
-rw-r--r--bounce.h1
-rw-r--r--client.c5
3 files changed, 3 insertions, 8 deletions
diff --git a/bounce.c b/bounce.c
index c6bd7b1..e113cc6 100644
--- a/bounce.c
+++ b/bounce.c
@@ -488,11 +488,12 @@ int main(int argc, char *argv[]) {
 	for (;;) {
 		enum Need needs = 0;
 		for (size_t i = clientIndex; i < event.len; ++i) {
+			struct Client *client = event.clients[i];
 			event.fds[i].events = POLLIN;
-			if (clientDiff(event.clients[i])) {
+			if (!client->need && ringDiff(client->consumer)) {
 				event.fds[i].events |= POLLOUT;
 			}
-			needs |= event.clients[i]->need;
+			needs |= client->need;
 		}
 
 		int timeout = 10000;
diff --git a/bounce.h b/bounce.h
index 3951599..434e443 100644
--- a/bounce.h
+++ b/bounce.h
@@ -227,7 +227,6 @@ void clientRecv(struct Client *client);
 void clientSend(struct Client *client, const char *ptr, size_t len);
 void clientFormat(struct Client *client, const char *format, ...)
 	__attribute__((format(printf, 2, 3)));
-size_t clientDiff(const struct Client *client);
 void clientConsume(struct Client *client);
 
 extern bool stateNoNames;
diff --git a/client.c b/client.c
index 29546f1..bad8c11 100644
--- a/client.c
+++ b/client.c
@@ -423,11 +423,6 @@ void clientRecv(struct Client *client) {
 	memmove(client->buf, line, client->len);
 }
 
-size_t clientDiff(const struct Client *client) {
-	if (client->need) return 0;
-	return ringDiff(client->consumer);
-}
-
 static int wordcmp(const char *line, size_t i, const char *word) {
 	if (line[0] == '@') {
 		line += strcspn(line, " ");
21Clean up unscoop manual pageJune McEnroe 2020-05-21Fix search expression appendJune McEnroe Oops. 2020-05-21Fix dbPrepare errx callJune McEnroe 2020-05-21Add only the necessary expressions to scoop's queryJune McEnroe This makes the queries generally faster and capable of taking advantage of any indexes that get created. 2020-05-21Explicitly set stdout line buffered when pagingJune McEnroe 2020-05-21Do not sort results in scoop by defaultJune McEnroe The -s flag now enables sorting (-g and -l also imply it), while the -S flag now launches the sqlite3 shell. Avoiding sorting by default is much faster and less memory-intensive as it doesn't require loading the entire result set into memory at once. 2020-05-21Expand and clarify documentationJune McEnroe 2020-05-21Execute PAGER with the SHELLJune McEnroe Same as how git executes it. Allows flags to be set in PAGER. 2020-05-21Automatically perform database migrations in litterboxJune McEnroe To simplify upgrades, restarting litterbox should be sufficient. The database can still be explicitly migrated with -m. 2020-05-20Don't install rc scripts on other platformsJune McEnroe Oops, meant to do this in the last commit. 2020-05-20Rewrite build and install like pounce 1.3June McEnroe man pages are no longer compressed! 2020-05-20Update email addressesJune McEnroe 2020-04-23Call updateConsumer from handleError 1.2p1June McEnroe This should prevent continually crashing on the same ERROR in the pounce buffer. 2020-04-20Use . as ${LDLIBS.$@} separatorJune McEnroe 2020-04-05Error on invalid ISUPPORT values 1.2June McEnroe 2020-04-05Only set RCS on FreeBSDJune McEnroe 2020-04-05Log bans and unbansJune McEnroe 2020-04-05Parse mode types from ISUPPORTJune McEnroe 2020-04-05Add unscoop matchers for ban/unban eventsJune McEnroe The IRC and Textual matchers miss bans mixed with other mode changes, but those are rare. 2020-04-05Check unscoop regexps with make testJune McEnroe 2020-04-05Add unscoop -n flag for checking regexpsJune McEnroe 2020-04-05Add Ban and Unban event typesJune McEnroe 2020-04-02Update styleJune McEnroe Replacing declarations followed by while loops with for loops and generating the short option string from the long options. 2020-03-31Update unscoop catgirl matchersJune McEnroe I'm not concerned about keeping the old matchers since I'm almost entirely certain I was the only one who ever used the old version of catgirl, and I already imported those logs. 2020-03-31Fix writing verbose to stderrJune McEnroe 2020-03-02Include <>/-/* around nicks in scoop coloring 1.1June McEnroe 2020-03-02Replace .mk files with configure scriptJune McEnroe 2020-02-28Implement the causal.agency/consumer capabilityJune McEnroe 2020-02-22Include <>/-/* around nicks in coloringJune McEnroe 2020-02-22Use (almost) the full range of IRC colors for nicksJune McEnroe