summary refs log tree commit diff
path: root/client.c
diff options
context:
space:
mode:
authorMichael Forney <mforney@mforney.org>2019-11-20 01:22:06 -0800
committerJune McEnroe <june@causal.agency>2019-11-21 16:26:37 -0500
commitf4b0d09e3f782511b99626104ca960dd5decd4b8 (patch)
treea7d7b4550e803624c9f33562ba89c0358b2019fe /client.c
parentZero temporary SASL PLAIN buffer (diff)
downloadpounce-f4b0d09e3f782511b99626104ca960dd5decd4b8.tar.gz
pounce-f4b0d09e3f782511b99626104ca960dd5decd4b8.zip
Declare globals as extern in headers, and define in source file
Otherwise, each source file that includes the header gets its own
definition, and according to the C standard (C99 6.9p5):

> If an identifier declared with external linkage is used in an
> expression (other than as part of the operand of a sizeof operator
> whose result is an integer constant), somewhere in the entire
> program there shall be exactly one external definition for the
> identifier

Most compilers use the .bss section for zero data, but if it uses
.data instead, or if -Wl,--warn-common is used, this will cause a
linking error.
Diffstat (limited to 'client.c')
-rw-r--r--client.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/client.c b/client.c
index d6b7b16..9ff192e 100644
--- a/client.c
+++ b/client.c
@@ -30,6 +30,9 @@
 
 #include "bounce.h"
 
+char *clientPass;
+char *clientAway;
+
 static size_t active;
 
 enum Need {
d>ui-patch: make sure to send http headersChristian Hesse 2015-08-13Makefile: make "git/config.mak.uname" inclusion optionalJohn Keeping 2015-08-13ui-shared: show full date in tooltip if longer ago than max_relativeJohn Keeping 2015-08-13ui-shared: use common function in print_rel_date()John Keeping 2015-08-13ui-shared: extract date formatting to a functionJohn Keeping 2015-08-13filter: don't use dlsym unnecessarilyJohn Keeping 2015-08-13ui-tree: use "sane" isgraph()John Keeping 2015-08-13cgit.h: move stdbool.h from ui-shared.hJohn Keeping 2015-08-13cache.c: fix header orderJohn Keeping 2015-08-13configfile.c: don't include system headers directlyJohn Keeping 2015-08-13Remove redundant includesJohn Keeping 2015-08-13Makefile: include Git's config.mak.unameJohn Keeping 2015-08-13tests: allow shell to be overriddenJohn Keeping 2015-08-13redirect: cleanlinessJason A. Donenfeld 2015-08-13redirect: be more careful for different cgi setupsJason A. Donenfeld 2015-08-12ui-log: fix double countingJohn Keeping 2015-08-12log: allow users to follow a fileJohn Keeping 2015-08-12shared: make cgit_diff_tree_cb publicJohn Keeping 2015-08-12t0110: Chain together using &&Jason A. Donenfeld 2015-08-12about: always ensure page has a trailing slashJason A. Donenfeld 2015-08-12filters: apply HTML escapingLazaros Koromilas 2015-08-12git: update to v2.5.0Christian Hesse 2015-08-12Fix processing of repo.hide and repo.ignoreDaniel Reichelt