summary refs log tree commit diff
path: root/client.c (follow)
Commit message (Expand)AuthorAge
* Add support for OpenBSDJune McEnroe2020-08-27
* Fix unintended interception of NICK after registrationJune McEnroe2020-08-13
* Implement stub of palaverapp.com capabilityJune McEnroe2020-08-11
* Refactor intercept to use Handlers and fix QUIT w/o message 1.4p1June McEnroe2020-08-10
* Refactor clientCA and clientSTS as clientCapsJune McEnroe2020-08-10
* Say "OpenSSL" in additional permission noticesJune McEnroe2020-08-06
* Handle broken clients sending only \nJune McEnroe2020-08-06
* Use snprintf instead of strlcpyJune McEnroe2020-07-31
* Add additional permission for linking with LibreSSLJune McEnroe2020-06-08
* Add server send queueing with time intervalJune McEnroe2020-05-11
* Advertise STS policyJune McEnroe2020-02-27
* Set consumer pos with CAP REQ causal.agency/consumer=nJune McEnroe2020-02-27
* Rename causal.agency/consumer tag causal.agency/posJune McEnroe2020-02-27
* Add 1 to consumer ID tagsJune McEnroe2020-02-27
* Add causal.agency/consumer capabilityJune McEnroe2020-02-27
* Send CAP LS 302 to the serverJune McEnroe2020-02-27
* Properly treat CAP LS version as a numberJune McEnroe2020-02-27
* Support CAP LS 302 from clientsJune McEnroe2020-02-27
* Support cap-notifyJune McEnroe2020-02-27
* Support setnameJune McEnroe2020-02-26
* Support labeled-responseJune McEnroe2020-02-26
* Support batchJune McEnroe2020-02-26
* Clean up intercept tag skipJune McEnroe2020-02-26
* Also skip the origin in wordcmpJune McEnroe2020-02-26
* Use %n for tags when formatting intercepted PRIVMSG/NOTICEJune McEnroe2020-02-26
* Tweak buffer sizesJune McEnroe2020-02-26
* Add time tag to lines missing itJune McEnroe2020-02-25
* Support message-tagsJune McEnroe2020-02-25
* Request server-time from the server and filter tags for clientsJune McEnroe2020-02-25
* Bump buffer sizes to allow for tagsJune McEnroe2020-02-25
* Remove bad assertJune McEnroe2020-02-18
* Add option to set local client CAJune McEnroe2020-01-12
* Add a vendor capability for passive clientsJune McEnroe2020-01-10
* Intercept client QUIT with no parameter 1.0p3June McEnroe2019-12-28
* Don't send self-PMs to the server 1.0p2June McEnroe2019-12-08
* Fix wordcmp return value when the words have differing lengthsMichael Forney2019-11-21
* Declare globals as extern in headers, and define in source fileMichael Forney2019-11-21
* client: Include time.h for gmtime and strftimeMichael Forney2019-11-20
* Format milliseconds as intJune McEnroe2019-11-20
* Add concept of passive clientsJune McEnroe2019-11-14
* Use struct timeval for sub-second precisionJune McEnroe2019-11-14
* Remove server-time filter TODOJune McEnroe2019-11-14
* Tweak filter regexesJune McEnroe2019-11-14
* Filter multi-prefixJune McEnroe2019-11-14
* Replace filters with regex replacesJune McEnroe2019-11-14
* Refactor filterUserhostInNamesJune McEnroe2019-11-13
* Factor out wordcpy for filtersJune McEnroe2019-11-13
* Skip initial NAMES parametersJune McEnroe2019-11-11
* Filter userhost-in-namesJune McEnroe2019-11-11
* Compare words without copying in filtersJune McEnroe2019-11-10
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-29 22:03:14 +0000
'>Update taglineJune McEnroe1&follow=1'>ui-patch: Flush stdout after outputting dataJohn Keeping It looks like cached patches are truncated to the nearest 1024-byte boundary in the patch body. E.g.: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:34:51 (80.4 MB/s) - ‘no-cache’ saved [4767] Patch is complete, without truncation. Next hit, with cache in place: > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4 > fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:35:01 (17.0 MB/s) - ‘yes-cache’ saved [4096/4096] Length truncated to 4096. The cache on disk looks truncated as well, so the bug must me during the process of saving cache. The same is true for larger patches: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:33 (1.07 MB/s) - ‘no-cache’ saved [979644] 979644 bytes with a cache-miss > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c > 566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:46 (1.05 MB/s) - ‘yes-cache’ saved [978944] 978944 (956KB exactly) with a cache-hit Since the "html" functions use raw write(2) to STDIO_FILENO, we don't notice problems with most pages, but raw patches write using printf(3). This is fine if we're outputting straight to stdout since the buffers are flushed on exit, but we close the cache output before this, so the cached output ends up being truncated. Make sure the buffers are flushed when we finish outputting a patch so that we avoid this. No other UIs use printf(3) so we do not need to worry about them. Actually, it's slightly more interesting than this... since we don't set GIT_FLUSH, Git decides whether or not it will flush stdout after writing each commit based on whether or not stdout points to a regular file (in maybe_flush_or_die()). Which means that when writing directly to the webserver, Git flushes stdout for us, but when we redirect stdout to the cache it points to a regular file so Git no longer flushes the output for us. The patch is still correct, but perhaps the full explanation is interesting! Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28ui-log: ignore unhandled argumentsJohn Keeping If you search for a bogus range string here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/ Using something like "range" and "qwerty123456", it returns an "Internal Server Error" and the following in the logs: > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] fatal: > ambiguous argument 'qwerty123456': unknown revision or path not in the > working tree., referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Use '--' to > separate paths from revisions, like this:, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] 'git <command> > [<revision>...] -- [<file>...]', referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Premature end > of script headers: cgit, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ The cache will kick in, so if you search for the same string again, it'll show an empty range, so you have to change the bogus strings each time. This is because we just pass the arguments straight to Git's revision parsing machinery which die()s if it cannot parse an argument, printing the above to stderr and exiting. The patch below makes it a bit friendlier by just ignoring unhandled arguments, but I can't see an easy way to report errors when we can't parse revision arguments without losing the flexibility of supporting all of the revision specifiers supported by Git. Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28git: update for git 2.0Christian Hesse prefixcmp() and suffixcmp() have been remove, functionality is now provided by starts_with() and ends_with(). Retrurn values have been changed, so instead of just renaming we have to fix logic. Everything else looks just fine. 2014-04-17remove trailing whitespaces from source filesChristian Hesse 2014-04-12git: update to 1.9.2Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-04-05Fix cgit_parse_url when a repo url is contained in another repo urlJulian Maurice For example, if I have two repos (remove-suffix is enabled): /foo /foo/bar http://cgit/foo/bar/ is interpreted as "repository 'foo', command 'bar'" instead of "repository 'foo/bar'" 2014-03-20Makefile: use more reliable git tarball mirrorJason A. Donenfeld 2014-03-20git: update to 1.9.1Christian Hesse