summary refs log tree commit diff
path: root/state.c (unfollow)
Commit message (Expand)Author
2019-11-06Use #defines for constant stringsJune McEnroe
2019-11-06Declare more missing functions and deal with lack of SO_NOSIGPIPEJune McEnroe
2019-11-06Define one CERTBOT_PATH rather than two format stringsJune McEnroe
2019-11-06Change license to GPLv3June McEnroe
2019-11-06Add flag to generate a client certificateJune McEnroe
2019-11-06Give SYNOPSIS Ars more informative namesJune McEnroe
2019-11-06Expand SASL EXTERNAL documentationJune McEnroe
2019-11-06Use explicit_bzero from LibreSSLJune McEnroe
2019-11-05Clean up bounce.cJune McEnroe
2019-11-05Use "priv" instead of "key" in optionsJune McEnroe
2019-11-05Use arc4random_bufJune McEnroe
2019-11-05Add missing includeJune McEnroe
2019-11-05Use one call to set client cert and keyJune McEnroe
2019-11-05Implement SASL EXTERNALJune McEnroe
2019-11-04Add options for TLS client certificateJune McEnroe
2019-11-04Zero PASS parameterJune McEnroe
2019-11-04Don't set directory modes on installJune McEnroe
2019-11-04Hash client passwords with cryptJune McEnroe
2019-11-04Move base64 to bounce.hJune McEnroe
2019-11-03Rename bind-unix to bind-pathJune McEnroe
2019-11-03Append bindHost to bindPath if it is a directoryJune McEnroe
2019-11-03Set up /var/run/calico and /usr/local/etc/pounceJune McEnroe
2019-11-02Set procname in calico rc scriptJune McEnroe
2019-11-02Send an unrecognized_name alert when failing to dispatchJune McEnroe
2019-11-02Fix name of SNIJune McEnroe
2019-11-02Unlink UNIX socket at exitJune McEnroe
2019-11-02Note calico in pounce CAVEATSJune McEnroe
2019-11-02Add calico rc scriptJune McEnroe
2019-11-02Apply capsicum to calicoJune McEnroe
2019-11-02Fix trying to cap_rights_limit a NULL saveFileJune McEnroe
2019-11-02Implement UNIX-domain bindingJune McEnroe
2019-11-02Don't try to sendfd if connect failedJune McEnroe
2019-11-02Document pounce -U flagJune McEnroe
2019-11-02Add SNI socket dispatcherJune McEnroe
2019-11-01Limit saveFile to CAP_WRITEJune McEnroe
2019-11-01Implement capsicum workaround for certbotJune McEnroe
2019-11-01Reload certificates using openatJune McEnroe
2019-11-01Re-read cert and key from the same FILEsJune McEnroe
2019-11-01Use capsicumJune McEnroe
2019-10-31Use explicit_bzero to clear passwordsJune McEnroe
2019-10-31Send clients their own QUIT on shutdownJune McEnroe
2019-10-31Shrink client buffer sizeJune McEnroe
2019-10-31Iterator over pollfds in reverseJune McEnroe
2019-10-31Clear passwords from memory with memset_sJune McEnroe
2019-10-30Clean up cert path documentationJune McEnroe
2019-10-30Remove client count FIXMEJune McEnroe
2019-10-30Preserve consumers ptr in realloc failureJune McEnroe
2019-10-30Add option for ring sizeJune McEnroe
2019-10-30Set away status upon connectingJune McEnroe
2019-10-30Add make target for localhost.crtJune McEnroe
diffstat but stops before printing (or generating) any of the body of the diff. No cgitrc option is added here so that we can wait to see how useful this is before letting people set it as the default. Suggested-by: Konstantin Ryabitsev <mricon@kernel.org> Signed-off-by: John Keeping <john@keeping.me.uk> 2014-12-13Change "ss" diff flag to an enumJohn Keeping This will allow us to introduce a new "stat only" diff mode without needing an explosion of mutually incompatible flags. The old "ss" query parameter is still accepted in order to avoid breaking saved links, but we no longer generate any URIs using it; instead the new "dt" (diff type) parameter is used. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-12-13ui-shared: remove toggle_ssdiff arg to cgit_diff_link()John Keeping This argument is never used with a value other than zero, so remove it and simplify the code. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-12-13ui-shared: remove toggle_ssdiff arg to cgit_commit_link()John Keeping This argument is never used with a value other than zero, so remove it and simplify the code. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-08-07git: update to v2.0.4John Keeping No CGit changes required. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-08-07Always check if README exists in choose_readme()Lukas Fleischer Specifying a nonexistent README file via the readme option is sometimes useful, e.g. when using scan-path and setting a global default. Currently, we check whether there is only one option in the readme option and, if so, we choose that file without checking whether it exists. As a consequence, all repositories are equipped with an about link in the aforementioned scenario, even if there is no about file. Remove the early check for the number of keys and always check whether the file exists instead. Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de> 2014-08-01cgitrc.5: we mean a cgi response, not requestJason A. Donenfeld 2014-07-28ui-stats.c: set parent pointer to NULL after freeing itJohn Keeping We do this everywhere else, so we should be doing it here as well. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-07-28git: update to v2.0.3John Keeping This is slightly more involved than just bumping the version number because it pulls in a change to convert the commit buffer to a slab, removing the "buffer" field from "struct commit". All sites that access "commit->buffer" have been changed to use the new functions provided for this purpose. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-07-28parsing.c: make commit buffer constJohn Keeping This will be required in order to incorporate the changes to commit buffer handling in Git 2.0.2. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-06-30Bump version.Jason A. Donenfeld 2014-06-29remove debug fprinf() calls that sneaked in with commit 79c985Christian Hesse 2014-06-28git: update to 2.0.1Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-06-28ui-patch: Flush stdout after outputting dataJohn Keeping It looks like cached patches are truncated to the nearest 1024-byte boundary in the patch body. E.g.: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:34:51 (80.4 MB/s) - ‘no-cache’ saved [4767] Patch is complete, without truncation. Next hit, with cache in place: > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4 > fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:35:01 (17.0 MB/s) - ‘yes-cache’ saved [4096/4096] Length truncated to 4096. The cache on disk looks truncated as well, so the bug must me during the process of saving cache. The same is true for larger patches: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:33 (1.07 MB/s) - ‘no-cache’ saved [979644] 979644 bytes with a cache-miss > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c > 566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:46 (1.05 MB/s) - ‘yes-cache’ saved [978944] 978944 (956KB exactly) with a cache-hit Since the "html" functions use raw write(2) to STDIO_FILENO, we don't notice problems with most pages, but raw patches write using printf(3). This is fine if we're outputting straight to stdout since the buffers are flushed on exit, but we close the cache output before this, so the cached output ends up being truncated. Make sure the buffers are flushed when we finish outputting a patch so that we avoid this. No other UIs use printf(3) so we do not need to worry about them. Actually, it's slightly more interesting than this... since we don't set GIT_FLUSH, Git decides whether or not it will flush stdout after writing each commit based on whether or not stdout points to a regular file (in maybe_flush_or_die()). Which means that when writing directly to the webserver, Git flushes stdout for us, but when we redirect stdout to the cache it points to a regular file so Git no longer flushes the output for us. The patch is still correct, but perhaps the full explanation is interesting! Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28ui-log: ignore unhandled argumentsJohn Keeping If you search for a bogus range string here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/ Using something like "range" and "qwerty123456", it returns an "Internal Server Error" and the following in the logs: > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] fatal: > ambiguous argument 'qwerty123456': unknown revision or path not in the > working tree., referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Use '--' to > separate paths from revisions, like this:, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] 'git <command> > [<revision>...] -- [<file>...]', referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Premature end > of script headers: cgit, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ The cache will kick in, so if you search for the same string again, it'll show an empty range, so you have to change the bogus strings each time. This is because we just pass the arguments straight to Git's revision parsing machinery which die()s if it cannot parse an argument, printing the above to stderr and exiting. The patch below makes it a bit friendlier by just ignoring unhandled arguments, but I can't see an easy way to report errors when we can't parse revision arguments without losing the flexibility of supporting all of the revision specifiers supported by Git. Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28git: update for git 2.0Christian Hesse prefixcmp() and suffixcmp() have been remove, functionality is now provided by starts_with() and ends_with(). Retrurn values have been changed, so instead of just renaming we have to fix logic. Everything else looks just fine. 2014-04-17remove trailing whitespaces from source filesChristian Hesse 2014-04-12git: update to 1.9.2Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-04-05Fix cgit_parse_url when a repo url is contained in another repo urlJulian Maurice For example, if I have two repos (remove-suffix is enabled): /foo /foo/bar http://cgit/foo/bar/ is interpreted as "repository 'foo', command 'bar'" instead of "repository 'foo/bar'" 2014-03-20Makefile: use more reliable git tarball mirrorJason A. Donenfeld 2014-03-20git: update to 1.9.1Christian Hesse