diff options
| author | Eric Wong <e@80x24.org> | 2019-01-04 22:23:24 +0000 |
|---|---|---|
| committer | June McEnroe <june@causal.agency> | 2021-01-17 20:03:45 +0000 |
| commit | a2bb7a9c44500342b99b274fce0a7b725b608f48 (patch) | |
| tree | 1c044659394a5157472bc2f2f8b2f2baa43fd72b | |
| parent | Improve decoration display for browsers without CSS (diff) | |
| download | src-a2bb7a9c44500342b99b274fce0a7b725b608f48.tar.gz src-a2bb7a9c44500342b99b274fce0a7b725b608f48.zip | |
Improve button spacing for browsers w/o CSS
For browsers on low-end machines running browsers without CSS support, the default tree view displayed "logplain" when it should be "log plain". Stop relying on CSS and add a space in between elements to improve accessibility.
| -rw-r--r-- | www/git.causal.agency/cgit/cgit.css | 1 | ||||
| -rw-r--r-- | www/git.causal.agency/cgit/ui-repolist.c | 2 | ||||
| -rw-r--r-- | www/git.causal.agency/cgit/ui-tree.c | 12 |
3 files changed, 11 insertions, 4 deletions
diff --git a/www/git.causal.agency/cgit/cgit.css b/www/git.causal.agency/cgit/cgit.css index b88db616..dac791b6 100644 --- a/www/git.causal.agency/cgit/cgit.css +++ b/www/git.causal.agency/cgit/cgit.css @@ -576,7 +576,6 @@ div#cgit table.list td.reposection { div#cgit a.button { font-size: 80%; - padding: 0em 0.5em; } div#cgit a.primary { diff --git a/www/git.causal.agency/cgit/ui-repolist.c b/www/git.causal.agency/cgit/ui-repolist.c index 529a2038..591929bb 100644 --- a/www/git.causal.agency/cgit/ui-repolist.c +++ b/www/git.causal.agency/cgit/ui-repolist.c @@ -353,8 +353,10 @@ void cgit_print_repolist(void) if (ctx.cfg.enable_index_links) { html("<td>"); cgit_summary_link("summary", NULL, "button", NULL); + html(" "); cgit_log_link("log", NULL, "button", NULL, NULL, NULL, 0, NULL, NULL, ctx.qry.showmsg, 0); + html(" "); cgit_tree_link("tree", NULL, "button", NULL, NULL, NULL); html("</td>"); } diff --git a/www/git.causal.agency/cgit/ui-tree.c b/www/git.causal.agency/cgit/ui-tree.c index 438b0011..34e7e63a 100644 --- a/www/git.causal.agency/cgit/ui-tree.c +++ b/www/git.causal.agency/cgit/ui-tree.c @@ -263,15 +263,21 @@ static int ls_item(const struct object_id *oid, struct strbuf *base, cgit_log_link("log", NULL, "button", ctx.qry.head, walk_tree_ctx->curr_rev, fullpath.buf, 0, NULL, NULL, ctx.qry.showmsg, 0); - if (ctx.repo->max_stats) + if (ctx.repo->max_stats) { + html(" "); cgit_stats_link("stats", NULL, "button", ctx.qry.head, fullpath.buf); - if (!S_ISGITLINK(mode)) + } + if (!S_ISGITLINK(mode)) { + html(" "); cgit_plain_link("plain", NULL, "button", ctx.qry.head, walk_tree_ctx->curr_rev, fullpath.buf); - if (!S_ISDIR(mode) && ctx.repo->enable_blame) + } + if (!S_ISDIR(mode) && ctx.repo->enable_blame) { + html(" "); cgit_blame_link("blame", NULL, "button", ctx.qry.head, walk_tree_ctx->curr_rev, fullpath.buf); + } html("</td></tr>\n"); cleanup: |