summary refs log tree commit diff
diff options
context:
space:
mode:
authorJune McEnroe <programble@gmail.com>2018-03-28 13:25:19 -0400
committerJune McEnroe <programble@gmail.com>2018-03-28 13:38:23 -0400
commitac48fa5a5c361ccbff39d453e53015e51acc8568 (patch)
tree468fa7087e074428cfa402e0e8b9990579096ebe
parentUse [[ ]] in zsh scripts (diff)
downloadsrc-ac48fa5a5c361ccbff39d453e53015e51acc8568.tar.gz
src-ac48fa5a5c361ccbff39d453e53015e51acc8568.zip
Fix shell script lints
-rwxr-xr-xlink.zsh6
-rwxr-xr-xpdf.zsh8
-rwxr-xr-xprune.zsh2
3 files changed, 10 insertions, 6 deletions
diff --git a/link.zsh b/link.zsh
index f5ed565c..8d573ceb 100755
--- a/link.zsh
+++ b/link.zsh
@@ -5,15 +5,15 @@ if [[ $# -eq 1 ]]; then
     linkPath="$1"
     filePath="$PWD/home/${linkPath#$HOME/}"
     [[ ! -f "$filePath" ]]
-    mkdir -p $(dirname "$filePath")
+    mkdir -p "$(dirname "$filePath")"
     mv "$linkPath" "$filePath"
 fi
 
-find home -type f | while read findPath; do
+find home -type f | while read -r findPath; do
     filePath="$PWD/$findPath"
     linkPath="$HOME/${findPath#home/}"
     [[ -L "$linkPath" ]] && continue
-    mkdir -p $(dirname "$linkPath")
+    mkdir -p "$(dirname "$linkPath")"
     ln -s "$filePath" "$linkPath"
     echo "$linkPath"
 done
diff --git a/pdf.zsh b/pdf.zsh
index 79e3309c..d9aab752 100755
--- a/pdf.zsh
+++ b/pdf.zsh
@@ -9,8 +9,12 @@ fetch() {
     echo "pdf/$1"
 }
 
-elf() { fetch "$1" "http://refspecs.linuxbase.org/elf/$2" }
-intel() { fetch "$1" "https://software.intel.com/sites/default/files/managed/$2" }
+elf() {
+    fetch "$1" "http://refspecs.linuxbase.org/elf/$2"
+}
+intel() {
+    fetch "$1" "https://software.intel.com/sites/default/files/managed/$2"
+}
 
 elf abi.pdf x86_64-abi-0.99.pdf
 elf elf.pdf elf.pdf
diff --git a/prune.zsh b/prune.zsh
index a0eb1f73..928fe066 100755
--- a/prune.zsh
+++ b/prune.zsh
@@ -1,7 +1,7 @@
 #!/usr/bin/env zsh
 set -o errexit -o nounset -o pipefail
 
-find -L ~ -type l -lname "$PWD/*" | while read linkPath; do
+find -L ~ -type l -lname "$PWD/*" | while read -r linkPath; do
     rm "$linkPath"
     echo "$linkPath"
 done
ffed514d39f2412061d1ccdd16044acbe98da8&follow=1'>Fix ncurses color pair numberingJune McEnroe This was dumb. Of course all the color pairs fit in 64, but I was shifting too much because my own representation includes the bright bit. 2018-04-09Use anonymous unionJune McEnroe 2018-04-09Replace #define with enum or const where possibleJune McEnroe 2018-03-31Link against ncursesJune McEnroe 2018-03-05Miscellaneous code cleanupJune McEnroe 2018-03-05Pass message structs by valueJune McEnroe 2018-03-05Use stdio in merge and metaJune McEnroe 2018-03-05Clean up spawn constantsJune McEnroe 2018-03-05Rename Tile timestamps {create,modify,access}TimeJune McEnroe 2018-03-05Pack message type enumsJune McEnroe 2018-03-05Undef COLOR_ constants in torus.hJune McEnroe 2018-03-05Generate tagsJune McEnroe 2017-10-03Simplify Makefile with pattern ruleJune McEnroe Insert rant about how GNU make handles the .c rule with extra dependencies. Also I don't care that everything links curses now. 2017-09-27Remove leading blank linesJune McEnroe 2017-09-27Add merge.c to READMEJune McEnroe 2017-09-03Assert client coords are valid after movementJune McEnroe 2017-09-03Relicense AGPLJune McEnroe I know it's already published under a permissive license in what is probably its final form, but I want to license it AGPL anyway on principle following some conversations I had about open source, corporations and copyleft. 2017-09-01Revert "Add client readOnly mode"June McEnroe This reverts commit 9a6c9c91c8092603b914cc0b3085d059e162ca29. 2017-09-01Remove clientRemove call from clientCastJune McEnroe If an error occurs on a client socket during a broadcast, that client will show up in the kqueue loop with EV_EOF and get removed that way. Tested by sending SIGKILL to a client and watching its cursor disappear. 2017-09-01Add client readOnly modeJune McEnroe 2017-08-31Clean up merge toolJune McEnroe Choose the version with the most recent access if the modify times are the same. 2017-08-31Choose B for tiles with equal modify timesJune McEnroe This way newer access counts and times will be preserved. 2017-08-31Add quick data file merge toolJune McEnroe Hopefully I won't have to use it ever again. 2017-08-30Use only foreground color for selecting spawnJune McEnroe 2017-08-29Add four additional spawnsJune McEnroe 2017-08-28Add respawningJune McEnroe 2017-08-26Move license above includesJune McEnroe Why was it down there? 2017-08-26Snapshot metadataJune McEnroe 2017-08-26Add meta.c to READMEJune McEnroe 2017-08-26Use MakefileJune McEnroe