diff options
author | June McEnroe <programble@gmail.com> | 2017-07-23 00:34:26 -0400 |
---|---|---|
committer | June McEnroe <programble@gmail.com> | 2017-07-23 00:34:26 -0400 |
commit | f90167e3f5975d20f487309baa369269ab0b1d73 (patch) | |
tree | eb0f10ff83c0535d8c10a63bfd26b2672f6b9c9f | |
parent | Clean up hnel a tiny bit (diff) | |
download | src-f90167e3f5975d20f487309baa369269ab0b1d73.tar.gz src-f90167e3f5975d20f487309baa369269ab0b1d73.zip |
Remove useless setuid in bri
Don't you think it would be better if the setuid bit only gave you permission to do it and didn't do it for you?
-rwxr-xr-x | curtis/.bin/bri.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/curtis/.bin/bri.c b/curtis/.bin/bri.c index 4c53475f..d085814b 100755 --- a/curtis/.bin/bri.c +++ b/curtis/.bin/bri.c @@ -1,7 +1,9 @@ #if 0 -cc -Wall -Wextra -pedantic $@ -o $(dirname $0)/bri $0 && \ -sudo chown root:root $(dirname $0)/bri && \ -sudo chmod u+s $(dirname $0)/bri +set -e +bin=$(dirname $0) +cc -Wall -Wextra -pedantic $@ -o $bin/bri $0 +sudo chown root:root $bin/bri +sudo chmod u+s $bin/bri exit #endif @@ -65,9 +67,6 @@ int main(int argc, char *argv[]) { value = buf; } - error = setuid(0); - if (error) err(EX_NOPERM, "setuid(0)"); - FILE *brightness = fopen("brightness", "w"); if (!brightness) err(EX_IOERR, "brightness"); |