summary refs log tree commit diff
path: root/bin/hi.c (follow)
Commit message (Expand)AuthorAge
* Don't match comments in strings in makeJune McEnroe2019-07-25
* Add diff syntax to hiJune McEnroe2019-07-01
* Highlight yacc and lex files as CJune McEnroe2019-05-10
* Use val instead of suboptargJune McEnroe2019-05-10
* Highlight line continuations in line commentsJune McEnroe2019-03-14
* Use getsubopt(3) to parse -o options in hiJune McEnroe2019-02-27
* Add type and ulimit shell keywordsJune McEnroe2019-02-27
* Fix make target pattern whitespace in hiJune McEnroe2019-02-27
* Match make targets as TagJune McEnroe2019-02-20
* Don't match nested parentheses in Tag for CJune McEnroe2019-02-18
* Match whitespace between * [] {}June McEnroe2019-02-18
* Fix function-like #define regexJune McEnroe2019-02-18
* Match Tag in RustJune McEnroe2019-02-18
* Match sh functions as TagJune McEnroe2019-02-18
* Match Sh and Ss as Tag in mdocJune McEnroe2019-02-18
* Match statics and typedefs as TagJune McEnroe2019-02-18
* Clean up htmlHeaderJune McEnroe2019-02-18
* Remove hi line numberingJune McEnroe2019-02-18
* Add Tag class to hiJune McEnroe2019-02-18
* Add hi -f html -o anchor for line number linksJune McEnroe2019-02-17
* Add line numbers to hiJune McEnroe2019-02-17
* Always split spans after newlinesJune McEnroe2019-02-17
* Highlight Interp as yellowJune McEnroe2019-02-15
* Highlight strings in sh command substitutionsJune McEnroe2019-02-15
* Match newlines in sh stringsJune McEnroe2019-02-13
* Fix sh comment pattern to require blankJune McEnroe2019-02-12
* Use a proper fread-realloc loop in hiJune McEnroe2019-02-12
* Don't match Rust raw strings inside other stringsJune McEnroe2019-02-12
* Add Rust to hiJune McEnroe2019-02-12
* Call setlocale in hiJune McEnroe2019-02-12
* Add plain text "language" to hiJune McEnroe2019-02-10
* Don't match DQ string inside SQ stringJune McEnroe2019-02-10
* Skip only one character if a match fails due to parentJune McEnroe2019-02-10
* Remove pattend from hiJune McEnroe2019-02-10
* Replace uses of pattend with newline patternsJune McEnroe2019-02-10
* Add hi debug outputJune McEnroe2019-02-10
* Actually do HTML " escapingJune McEnroe2019-02-10
* Add back missing static keywordJune McEnroe2019-02-10
* Add tab option to HTML output of hiJune McEnroe2019-02-09
* Add css and inline HTML options to hiJune McEnroe2019-02-09
* Combine all Keyword patternsJune McEnroe2019-02-09
* Fix IRC output monospace option to emit once per lineJune McEnroe2019-02-09
* Add output format options to hiJune McEnroe2019-02-09
* Avoid using SGRReset and IRCResetJune McEnroe2019-02-09
* Use X macros for hi classesJune McEnroe2019-02-08
* Add sh syntax to hiJune McEnroe2019-02-08
* Use [] to quote special characters in regexJune McEnroe2019-02-08
* Improve ANSI output and base IRC on itJune McEnroe2019-02-08
* Add hi -nJune McEnroe2019-02-08
* Use set for parent in hiJune McEnroe2019-02-08
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-06-05 23:02:27 +0000
=4b91269bdbc21a664cc56c26d6071c630560f2e0&follow=1'>remove debug fprinf() calls that sneaked in with commit 79c985Christian Hesse 2014-06-28git: update to 2.0.1Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-06-28ui-patch: Flush stdout after outputting dataJohn Keeping It looks like cached patches are truncated to the nearest 1024-byte boundary in the patch body. E.g.: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:34:51 (80.4 MB/s) - ‘no-cache’ saved [4767] Patch is complete, without truncation. Next hit, with cache in place: > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4 > fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:35:01 (17.0 MB/s) - ‘yes-cache’ saved [4096/4096] Length truncated to 4096. The cache on disk looks truncated as well, so the bug must me during the process of saving cache. The same is true for larger patches: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:33 (1.07 MB/s) - ‘no-cache’ saved [979644] 979644 bytes with a cache-miss > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c > 566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:46 (1.05 MB/s) - ‘yes-cache’ saved [978944] 978944 (956KB exactly) with a cache-hit Since the "html" functions use raw write(2) to STDIO_FILENO, we don't notice problems with most pages, but raw patches write using printf(3). This is fine if we're outputting straight to stdout since the buffers are flushed on exit, but we close the cache output before this, so the cached output ends up being truncated. Make sure the buffers are flushed when we finish outputting a patch so that we avoid this. No other UIs use printf(3) so we do not need to worry about them. Actually, it's slightly more interesting than this... since we don't set GIT_FLUSH, Git decides whether or not it will flush stdout after writing each commit based on whether or not stdout points to a regular file (in maybe_flush_or_die()). Which means that when writing directly to the webserver, Git flushes stdout for us, but when we redirect stdout to the cache it points to a regular file so Git no longer flushes the output for us. The patch is still correct, but perhaps the full explanation is interesting! Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28ui-log: ignore unhandled argumentsJohn Keeping If you search for a bogus range string here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/ Using something like "range" and "qwerty123456", it returns an "Internal Server Error" and the following in the logs: > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] fatal: > ambiguous argument 'qwerty123456': unknown revision or path not in the > working tree., referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Use '--' to > separate paths from revisions, like this:, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] 'git <command> > [<revision>...] -- [<file>...]', referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Premature end > of script headers: cgit, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ The cache will kick in, so if you search for the same string again, it'll show an empty range, so you have to change the bogus strings each time. This is because we just pass the arguments straight to Git's revision parsing machinery which die()s if it cannot parse an argument, printing the above to stderr and exiting. The patch below makes it a bit friendlier by just ignoring unhandled arguments, but I can't see an easy way to report errors when we can't parse revision arguments without losing the flexibility of supporting all of the revision specifiers supported by Git. Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28git: update for git 2.0Christian Hesse prefixcmp() and suffixcmp() have been remove, functionality is now provided by starts_with() and ends_with(). Retrurn values have been changed, so instead of just renaming we have to fix logic. Everything else looks just fine. 2014-04-17remove trailing whitespaces from source filesChristian Hesse 2014-04-12git: update to 1.9.2Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-04-05Fix cgit_parse_url when a repo url is contained in another repo urlJulian Maurice For example, if I have two repos (remove-suffix is enabled): /foo /foo/bar http://cgit/foo/bar/ is interpreted as "repository 'foo', command 'bar'" instead of "repository 'foo/bar'" 2014-03-20Makefile: use more reliable git tarball mirrorJason A. Donenfeld 2014-03-20git: update to 1.9.1Christian Hesse