about summary refs log tree commit diff homepage
Commit message (Expand)AuthorAge
* Build chroot only for OpenBSD, remove rc scriptJune McEnroe2021-10-17
* Fix backspace on OpenBSDJune McEnroe2021-09-28
* Handle KCGI_EXIT gracefullyJune McEnroe2021-09-27
* Call msync(2) after modifying tilesJune McEnroe2021-09-27
* Copy CSVs to web directory from snapshot.shJune McEnroe2021-09-27
* Extract chroot.tar with -p, install to WEBROOTJune McEnroe2021-09-27
* OpenBSD: Copy appropriate files for chrootJune McEnroe2021-09-26
* OpenBSD: pledge(2) imageJune McEnroe2021-09-26
* OpenBSD: pledge(2) clientJune McEnroe2021-09-26
* OpenBSD: pledge(2) serverJune McEnroe2021-09-26
* Link with -lncurseswJune McEnroe2021-09-24
* Replace strlcpy with snprintfJune McEnroe2021-09-20
* Replace kqueue with poll, remove libutil dependencyJune McEnroe2021-09-20
* Update play@ascii.town descriptionJune McEnroe2021-02-04
* Replace donation button with LiberapayJune McEnroe2021-02-04
* Use DisableForwarding in sshd_configJune McEnroe2020-06-25
* Remove READMEJune McEnroe2019-12-19
* Update git URLsJune McEnroe2019-12-15
* Add buymeacoffee linkJune McEnroe2019-08-05
* Use braces in MakefileJune McEnroe2019-07-27
* Make copyright headers consistentJune McEnroe2019-07-27
* Remove NetHack from indexJune McEnroe2019-07-08
* Don't install rc.kfcgi eitherJune McEnroe2019-04-08
* Remove rc.kfcgiJune McEnroe2019-03-28
* Reformat index.html with explore linkJune McEnroe2019-01-16
* Return false from keydown handler in exploreJune McEnroe2019-01-16
* Draw lines to tile edgeJune McEnroe2019-01-08
* Factor out default pathsJune McEnroe2019-01-08
* Remove incorrect default coordinatesJune McEnroe2019-01-08
* Set img src when explore fragment changesJune McEnroe2019-01-07
* Compress PNG data in imageJune McEnroe2019-01-07
* madvise MADV_NOCORE in imageJune McEnroe2019-01-07
* Add license notice to explore JavaScriptJune McEnroe2019-01-07
* Add Q/Home binding in exploreJune McEnroe2019-01-07
* Fix explore image URLJune McEnroe2019-01-07
* Add HOME button, ssh link, AGPL notice to exploreJune McEnroe2019-01-07
* Add meta viewport to exploreJune McEnroe2019-01-06
* Set background and max-width in exploreJune McEnroe2019-01-06
* Swallow writes after the connection is closedJune McEnroe2019-01-06
* Handle KCGI_HUPJune McEnroe2019-01-06
* Install html filesJune McEnroe2019-01-06
* Add explore.htmlJune McEnroe2019-01-06
* Use req.fieldmapJune McEnroe2019-01-06
* Add kfcgi rc fileJune McEnroe2019-01-06
* Add image and font to chrootJune McEnroe2019-01-06
* Add kcgi support to imageJune McEnroe2019-01-06
* Add cap_rights_limit calls to client and serverJune McEnroe2019-01-04
* Add play to index.htmlJune McEnroe2019-01-04
* Merge branch 'backport'June McEnroe2019-01-04
|\
| * Re-create help pageJune McEnroe2019-01-04
generated by cgit-pink 1.4.1 (git 2.36.1) at 2026-09-21 11:37:05 +0000
/cgit-pink/commit/git?h=1.4.1&id=390ffad022336b02dca6dec23504cefeb12adada&follow=1'>git: update to 2.0.1Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-06-28ui-patch: Flush stdout after outputting dataJohn Keeping It looks like cached patches are truncated to the nearest 1024-byte boundary in the patch body. E.g.: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:34:51 (80.4 MB/s) - ‘no-cache’ saved [4767] Patch is complete, without truncation. Next hit, with cache in place: > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4 > fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:35:01 (17.0 MB/s) - ‘yes-cache’ saved [4096/4096] Length truncated to 4096. The cache on disk looks truncated as well, so the bug must me during the process of saving cache. The same is true for larger patches: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:33 (1.07 MB/s) - ‘no-cache’ saved [979644] 979644 bytes with a cache-miss > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c > 566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:46 (1.05 MB/s) - ‘yes-cache’ saved [978944] 978944 (956KB exactly) with a cache-hit Since the "html" functions use raw write(2) to STDIO_FILENO, we don't notice problems with most pages, but raw patches write using printf(3). This is fine if we're outputting straight to stdout since the buffers are flushed on exit, but we close the cache output before this, so the cached output ends up being truncated. Make sure the buffers are flushed when we finish outputting a patch so that we avoid this. No other UIs use printf(3) so we do not need to worry about them. Actually, it's slightly more interesting than this... since we don't set GIT_FLUSH, Git decides whether or not it will flush stdout after writing each commit based on whether or not stdout points to a regular file (in maybe_flush_or_die()). Which means that when writing directly to the webserver, Git flushes stdout for us, but when we redirect stdout to the cache it points to a regular file so Git no longer flushes the output for us. The patch is still correct, but perhaps the full explanation is interesting! Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28ui-log: ignore unhandled argumentsJohn Keeping If you search for a bogus range string here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/ Using something like "range" and "qwerty123456", it returns an "Internal Server Error" and the following in the logs: > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] fatal: > ambiguous argument 'qwerty123456': unknown revision or path not in the > working tree., referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Use '--' to > separate paths from revisions, like this:, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] 'git <command> > [<revision>...] -- [<file>...]', referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Premature end > of script headers: cgit, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ The cache will kick in, so if you search for the same string again, it'll show an empty range, so you have to change the bogus strings each time. This is because we just pass the arguments straight to Git's revision parsing machinery which die()s if it cannot parse an argument, printing the above to stderr and exiting. The patch below makes it a bit friendlier by just ignoring unhandled arguments, but I can't see an easy way to report errors when we can't parse revision arguments without losing the flexibility of supporting all of the revision specifiers supported by Git. Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28git: update for git 2.0Christian Hesse prefixcmp() and suffixcmp() have been remove, functionality is now provided by starts_with() and ends_with(). Retrurn values have been changed, so instead of just renaming we have to fix logic. Everything else looks just fine. 2014-04-17remove trailing whitespaces from source filesChristian Hesse 2014-04-12git: update to 1.9.2Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-04-05Fix cgit_parse_url when a repo url is contained in another repo urlJulian Maurice For example, if I have two repos (remove-suffix is enabled): /foo /foo/bar http://cgit/foo/bar/ is interpreted as "repository 'foo', command 'bar'" instead of "repository 'foo/bar'" 2014-03-20Makefile: use more reliable git tarball mirrorJason A. Donenfeld 2014-03-20git: update to 1.9.1Christian Hesse